385939 - Auto-whowas doesn't work on freenode

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Rob Marshall [tH]]

When you do /whois on a non-existent nick, freenode sends the 401 message (no such nick), but doesn't send the 318 (end of whois). As a result ChatZilla doesn't display anything and doesn't trigger the whowas.

Comment 1

[Rob Marshall [tH]]

Attachment: patch

This moves the whowas call to on401 so it happens even if the "end of whois" message isn't received. Tested on all the built-in networks, except hybridnet which I couldn't connect to.

Comment 2

[:Gijs (he/him)]

Comment on attachment 281694 [details] [diff] [review]
patch

<snip>
>-            // If this user isn't here, don't display anything and do a whowas
>+            // If we already sent a whowas, don't display anything

I would prefer to keep the notion of the user not being there, because the if statement doesn't really have anything to do with the fact that we sent a whowas - it's just confusing like this. Feel free to use 2 lines of comments if you can't fit it otherwise... :P


with that,
r=gijs

Comment 3

[Rob Marshall [tH]]

Attachment: for checkin

Just changed the comment.

Comment 4

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v  <--  handlers.js
new revision: 1.155; previous revision: 1.154
done