Closed
Bug 385982
Opened 18 years ago
Closed 18 years ago
WebContentConverterRegistrar in cycle with nsJSID
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sayrer, Assigned: sayrer)
References
Details
Attachments
(1 file)
|
2.47 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
This is probably what causes leaks with XPCOMUtils as well, since the nsJSID is assigned to the object's prototype in that case. In this case, WCCR has its id assigned to itself so that it can implement nsIClassInfo.
|
Assignee | |
Comment 1•18 years ago
|
||
The nsJSID stuff could probably use some cycle collection, but I'm not sure which of the various wrappers need it.
|
|
Assignee | |
Comment 2•18 years ago
|
||
Comment on attachment 269926 [details] [diff] [review]
null out classID
while I'm in the neighborhood, delete an unused and duplicated IID that I discovered during debugging.
Attachment #269926 -
Flags: review? → review?(gavin.sharp)
|
||
Updated•18 years ago
|
Attachment #269926 -
Flags: review?(gavin.sharp) → review+
|
||
Comment 3•18 years ago
|
||
Here are the leaks this patch fixed, FWIW.
--FIXED-LEAKS------------------------leaks------leaks%
XPCWrappedNative 1400 -3.85%
nsJSID 0 -100.00%
TOTAL 1400
|
|
Assignee | |
Comment 4•18 years ago
|
||
Filed bug 385993 on the cycle.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•