386101 - enable breakpad by default on Linux

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

Attachment: enable breakpad on all platforms if MOZILLA_OFFICIAL

We're building it, we might as well enable it.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 270058 [details] [diff] [review]
enable breakpad on all platforms if MOZILLA_OFFICIAL

got rs=gavin on irc, checked in.

Comment 2

[(not currently active) Ted Mielczarek]

sayrer backed this out last night to try to fix some orange.

Comment 3

[(not currently active) Ted Mielczarek]

This doesn't make me super happy:
ttps://crash-reports.mozilla.com/reports/report/index/49103875-256d-11dc-b7d7-001a4bd43e5c

Comment 4

[(not currently active) Ted Mielczarek]

Local testing reveals:
2007-06-24 00:26:08: basic_source_line_resolver.cc:195: INFO: Loading symbols fo
r module /home/breakpad/firefox/libxul.so from /home/breakpad/symbol-store/apps/
libxul.so/A1CA5C371B7E92D0949261D0C87DCDA30/libxul.so.sym
2007-06-24 00:26:08: basic_source_line_resolver.cc:303: ERROR: ParseLine failed 
at /home/breakpad/symbol-store/apps/libxul.so/A1CA5C371B7E92D0949261D0C87DCDA30/
libxul.so.sym:674799
That line in particular is the line right below this FUNC line:
FUNC 804a53 59 0 sqlite3ExprSpan
804a53 8 -28379 2925

Not so good!  I'm going to file this upstream.  This makes me believe we shouldn't bother enabling Breakpad on Linux for a6, since we're not going to get good crash reports anyway.

Comment 5

[(not currently active) Ted Mielczarek]

Filed upstream: http://code.google.com/p/google-breakpad/issues/detail?id=191

Comment 6

[(not currently active) Ted Mielczarek]

This got checked back in, I'm working on the dump_syms problem.