386103 - Localizability issues with search engine aliases

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Marek Stępień [:marcoos, inactive]]

The duplicateTitle/duplicateBookmark properties aren't really localizable in their current form.

Copying&pasting to what I wrote in bug 378553:

(In reply to bug 378553 comment #10)
> >Index: components/search/content/engineManager.js
> 
> >+  editKeyword: function engineManager_editKeyword() {
> 
> >+        var dtitle = strings.getString("duplicateTitle");
> >+        var bookmark = strings.getString("duplicateBookmark");
> >+        var dmsg = strings.getFormattedString("duplicateMsg",
> >+                                         [(bduplicate) ? bookmark : '"' +
> >+                                          engine.name + '"']);
> 
> We might end up having to change this to a fully localized string, if the hard
> coded quotes aren't suitable here for some locales, but we can cross that
> bridge when we come to it, I think.

Quotes are only part of the problem, not the most imporant one, though.

I really can't localize a sentence like this one into Polish. The word
"bookmark" is declensed differently than the word for "search engine" - which I
need to use as a prefix, so that I don't need to declense the (unknown!) name
of the search engine.

I mean, the Polish translation would be: "Wybrałeś słowo kluczowe używane
przez wyszukiwarkę %S", where "wyszukiwarkę" is the declensed word
"wyszukiwarka" = search engine. 

This translated back into English would be:
"You have chosen a keyword that is currently in use by the %S search engine."

so we CAN'T really have %S evaluate to "a bookmark".

This should be split into two strings, like this:

duplicateMsgEngine=You have chosen a keyword that is currently in use by %S.
Please select another.
duplicateMsgBookmark=You have chosen a keyword that is currently in use by a
bookmark. Please select another.

reopening, ccing Pike.

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/browser/components/search/content/engineManager.js 	1.16 	mozilla/browser/locales/en-US/chrome/browser/engineManager.properties 	1.2 

Comment 3

[Marek Stępień [:marcoos, inactive]]

verified with  Mozilla/5.0 (Macintosh; U; Intel Mac OS X; pl; rv:1.9a6pre) Gecko/2007070204 Minefield/3.0a6pre