Closed Bug 386255 Opened 13 years ago Closed 13 years ago

Trunk XULRunner compile error in nsIEditingSession::MakeWindowEditable

Categories

(Toolkit Graveyard :: XULRunner, defect)

x86
Windows Vista
defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stephend, Assigned: peterv)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

(I'm filing proxy for bent and weirdal on IRC; I don't actually build, FWIW.)

There's a compile error in trunk XULRunner (see https://bugzilla.mozilla.org/show_bug.cgi?id=237964#c78)

mozilla/embedding/browser/activex/src/control/MozillaBrowser.cpp(1295) : error
C2660: 'nsIEditingSession::MakeWindowEditable' : function does not take 4
arguments
Attached patch Bustage patch (obsolete) — Splinter Review
I guessed PR_FALSE... is that ok?
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #270235 - Flags: review?
Attachment #270235 - Flags: review? → review?(jonas)
Comment on attachment 270235 [details] [diff] [review]
Bustage patch

Lets get the bustage fix in, and get peters input on if this is the right fix later.
Attachment #270235 - Flags: review?(jonas) → review+
mconnor wants this to wait until the tree is reopened
Attached patch Bustage patchSplinter Review
Sorry about that. Should be true actually, the document needs to be completely editable.
Assignee: bent.mozilla → peterv
Attachment #270235 - Attachment is obsolete: true
Attachment #270290 - Flags: review?(jonas)
This was checked in a while ago.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
-> VERIFIED
Status: RESOLVED → VERIFIED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.