Closed Bug 386267 Opened 17 years ago Closed 17 years ago

add "Copy" context menu item for containers/folder in the history sidebar

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Firefox 3 alpha8

People

(Reporter: moco, Assigned: christineyen+bugs)

References

Details

Attachments

(2 files)

add "Copy" context menu item for containers/folder in the history sidebar

screen shot coming.

Note, Edit | Copy is enabled (but doesn't work, see bug #364298)

And, dnd from history sidebar to bookmarks toolbar works, but doesn't work (again, see bug #364298)

Finally, all of this depends on christine's work in bug #378558.

For history sidebar containers, we will need her work to convert to both HTML and the json representation.
Flags: blocking-firefox3?
Assignee: nobody → cyen
Attached patch patchSplinter Review
Attachment #270600 - Flags: review?(sspitzer)
Comment on attachment 270600 [details] [diff] [review]
patch

r=sspitzer

question:  did fx 2 have this menuitem?

still seeking ui-r from beltzner (or faaborg, or mconnor)
Attachment #270600 - Flags: ui-review?(beltzner)
Attachment #270600 - Flags: review?(sspitzer)
Attachment #270600 - Flags: review+
> question:  did fx 2 have this menuitem?

it did not, at least not on mac.  we had "Expand" and "Delete".  

Should "Expand" come back?  I'll take that to another spin off bug and see what the UI folk think.
Status: NEW → ASSIGNED
fx 2 didn't, but its edit menu had "copy" enabled, as in minefield... see semirelated comments here
https://bugzilla.mozilla.org/show_bug.cgi?id=364298#c2

For that matter, the context menu has a disabled "New Bookmark" item... I wasn't sure if that was intentional or not. Plus, the "Delete" menuitem is visible + enabled but deleting folders seems to be disabled under the History sidebar (but folders magically disappear once their children are all deleted)

I'll spin off the delete issue into another bug unless it's addressed elsewhere.
> I'll spin off the delete issue into another bug unless it's addressed
> elsewhere.
> 

Just kidding, sorry for the bug spam - deletion was mentioned in Bug 376706
> I'll take that to another spin off bug and see what the UI folk think.

see bug #386644
> For that matter, the context menu has a disabled "New Bookmark" item...

good catch.  For the history menu, since it is always disabled, can you log a spin off bug about hiding that item?

> Plus, the "Delete" menuitem is visible + enabled but...

As you pointed out, that is a known issue already logged.

Hoping we get ui-r so we can land your fix for b1.
Target Milestone: --- → Firefox 3 beta1
> can you log a spin off bug about hiding that item?

When did I get so lazy?  logged bug #386876 on this issue.
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [wanted-firefox3]
Comment on attachment 270600 [details] [diff] [review]
patch

ui-r=me, let's get this in.  I'm not 100% sure, but it seems like a useful thing to have in the menu.
Attachment #270600 - Flags: ui-review?(beltzner) → ui-review+
I'm not sure what the paste target would be here ... 
Comment on attachment 270600 [details] [diff] [review]
patch

Ok, wait, I think my brain fell asleep.  Is this to copy an entire day of history results to the bookmark folder?  I don't know if I see that as a task we care about... need to rethink more when its not 3 AM
Attachment #270600 - Flags: ui-review+ → ui-review?
Comment on attachment 270600 [details] [diff] [review]
patch

Heh, I'm actually confident enough to minus this. Copy isn't the right metaphor at the folder level, here.

Instead, we should be enabling things like Copy on single or multiple item select, and then shortcuts to create saved searches from folders for a specific day, which would then appear as a bookmark folder of "History: July 24th, 2007"
Attachment #270600 - Flags: ui-review? → ui-review-
Ok, yeah, that makes sense.

I don't think I meant to block on this, actually, given that I set [wanted]

We do want some way of getting history items bookmarked, but I think the folder isn't the thing anyone's going to copy.
Flags: blocking-firefox3+ → blocking-firefox3-
Blocks: 364298
No longer depends on: 364298
No longer blocks: 364298
(In reply to comment #13)
> (From update of attachment 270600 [details] [diff] [review])
> Heh, I'm actually confident enough to minus this. Copy isn't the right metaphor
> at the folder level, here.
> 
> Instead, we should be enabling things like Copy on single or multiple item
> select, and then shortcuts to create saved searches from folders for a specific
> day, which would then appear as a bookmark folder of "History: July 24th, 2007"

Multiple item select actually isn't possible in the history tree - so creating saved searches would then be the only way to copy all history links from one day/site...

If we're doing without the context menu item, though, I just wanted to make sure that we know that Copy is still enabled through the edit menu (as Seth pointed out in comment #0 and as mentioned in recent comments in bug 364298). So ui-'ing this bug just removes the visual reminder that that's possible for folders, not the functionality. (And if that was the intention... my mistake. :))
Target Milestone: Firefox 3 M7 → Firefox 3 M8
marking WONTFIX per comment #13
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Flags: wanted-firefox3+
Whiteboard: [wanted-firefox3]
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: