386291 - new mail notification displays doubled subjects on IMAP

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Attachment: sceenshot when receiving one new message

For IMAP I have started getting wrong info in the new mail notification. If I get one new message, it displays the subject and from like I got two messages from the same thread. This also causes the notification to look cut off. See the screenshot.

This regression is not very fresh, I think I've seen it for about a month. Trunk only. POP accounts don't seem to be affected.

Comment 1

[Scott MacGregor]

I've been seeing this for quite a while too on the trunk. Probably close to two months now. I haven't gotten around to figuring out when it regressed. Maybe we can get a couple folks to help track down a regression window.

Comment 2

[David :Bienvenu]

I've debugged this a bit - I suspect we're getting two notifications when the imap fetch of the headers is done, or something like that - we're getting into newmailalert.xul's parseFolder method twice, each time, adding the subject for the new mail to the alert.

Comment 3

[David :Bienvenu]

I suspect the issue is that nsIMsgFolder::FetchMsgPreviewText returns a boolean, but js calling code treats it as an out parameter. I know the async return value isn't getting set properly, causing us to add the msg to the popup twice.

Comment 4

[David :Bienvenu]

Attachment: proposed fix

Comment 5

[Scott MacGregor]

Comment on attachment 271252 [details] [diff] [review]
proposed fix

ah nsIMsgFolder API cleanup fall out. Thanks David!

Comment 6

[Magnus Melin [:mkmelin]]

Verified fixed on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a7pre) Gecko/2007070803 Thunderbird/3.0a1pre ID:2007070803