Open
Bug 386334
Opened 17 years ago
Updated 2 years ago
make the format of the date line in message pane configurable
Categories
(MailNews Core :: Localization, enhancement)
MailNews Core
Localization
Tracking
(Not tracked)
NEW
People
(Reporter: ch.ey, Assigned: ch.ey)
Details
(Whiteboard: [patchlove])
Attachments
(1 file, 1 obsolete file)
7.40 KB,
patch
|
Bienvenu
:
review-
|
Details | Diff | Splinter Review |
The format of the date column in the thread pane is configurable via the mail.ui.display.dateformat.* prefs. I was asked to make this configurable and here's my proposal. The patch is a twofold change. Firstly the date string now can in one of three instead of two formats (added format for same week) like in the thread pane. Secondly it's configurable using a set of new prefs mail.ui.display.dateformat_header.*. If a pref from this branch is not set, it's tried to be retrieved from the dateformat.* branch before falling back to the default. The main ingredients of this patch have been copied over from nsMsgDBView.cpp like it has been done with the code for nsMimeHtmlDisplayEmitter::GenerateDateString() in the past. Question is if the common code from these fuction should be sourced out to a common function. Also some portion from nsMsgGroupView::AllocHashKeyForHdr() is the same.
Updated•16 years ago
|
Product: Core → MailNews Core
Comment 1•15 years ago
|
||
Jonathan what was the bug you fixed regarding dates ?
Whiteboard: [patchlove]
Comment 2•15 years ago
|
||
bug 360018
Comment 3•15 years ago
|
||
Comment on attachment 270330 [details] [diff] [review] proposed patch Patch has unfortunately bitrotted: $ patch -p1 --dry-run < ~/Desktop/attachment.cgi patching file mime/emitters/src/nsMimeHtmlEmitter.cpp Hunk #1 succeeded at 122 (offset 42 lines). Hunk #2 FAILED at 324. Hunk #3 FAILED at 390. 2 out of 3 hunks FAILED -- saving rejects to file mime/emitters/src/nsMimeHtmlEmitter.cpp.rej patching file mime/emitters/src/nsMimeHtmlEmitter.h Hunk #1 FAILED at 87. 1 out of 1 hunk FAILED -- saving rejects to file mime/emitters/src/nsMimeHtmlEmitter.h.rej
Attachment #270330 -
Attachment is obsolete: true
Comment 4•15 years ago
|
||
Christian, any chance of a new patch?
Assignee | ||
Comment 5•15 years ago
|
||
Updated patch, it now also gives consistent results when the pref mailnews.display.date_senders_timezone is true. But please test this someone with some edge cases of dates for the today, this week and older. And please give me some feedback on the new prefs.
Assignee: nobody → ch.ey
Comment 6•15 years ago
|
||
(In reply to comment #5) > Created an attachment (id=385641) [details] > proposed path v2 > > Updated patch, it now also gives consistent results when the pref > mailnews.display.date_senders_timezone is true. > But please test this someone with some edge cases of dates for the today, this > week and older. > And please give me some feedback on the new prefs. Christian, please request a review from any of the reviewers: http://www.mozilla.org/mailnews/review.html
Updated•15 years ago
|
Attachment #385641 -
Flags: review?(bugzilla)
Comment 7•15 years ago
|
||
Comment on attachment 385641 [details] [diff] [review] proposed path v2 Sorry I've not got to this. I think David knows mime and date type things a bit more, so I'm going to pass it to him and hope he's quicker than me.
Attachment #385641 -
Flags: review?(bugzilla) → review?(bienvenu)
Comment 8•15 years ago
|
||
Christian, thx for the patch. We no longer need to use the LL macro's so that should get cleaned up in this patch...I'll try to look at this in a bit...
Comment 9•14 years ago
|
||
Comment on attachment 385641 [details] [diff] [review] proposed path v2 Patch can still be applied! :) bienvenu, review-ping? $ patch -p1 --dry-run < ~/Desktop/p386334.diff patching file mailnews/mime/emitters/src/nsMimeHtmlEmitter.cpp Hunk #1 succeeded at 121 (offset -1 lines). Hunk #2 succeeded at 316 (offset -1 lines). Hunk #3 succeeded at 404 (offset -1 lines). patching file mailnews/mime/emitters/src/nsMimeHtmlEmitter.h
Comment 10•14 years ago
|
||
Comment on attachment 385641 [details] [diff] [review] proposed path v2 patch is still using the LL macros per my previous comment, and shouldn't. don't need to init rv here: + nsresult rv = NS_OK; seems like this code could be shared with the view code that has to do similar things (but doesn't do the GMTCompTimeShift stuff)
Attachment #385641 -
Flags: review?(bienvenu) → review-
Comment 11•9 years ago
|
||
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•