Closed
Bug 386369
Opened 19 years ago
Closed 19 years ago
Use getters and setters for database schema version
Categories
(Core :: Networking: Cookies, defect)
Core
Networking: Cookies
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.70 KB,
patch
|
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/cookie/src/nsCookieService.cpp&rev=1.64#448
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/cookie/src/nsCookieService.cpp&rev=1.64#469
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/cookie/src/nsCookieService.cpp&rev=1.64#445
|
Assignee | |
Updated•19 years ago
|
|
||
Updated•19 years ago
|
Assignee: nobody → dwitte
|
|
||
Updated•19 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•19 years ago
|
||
not sure who a good sr is - please advise
Assignee: dwitte → sdwilsh
Attachment #270557 -
Flags: review?(dwitte)
|
|
||
Comment 2•19 years ago
|
||
Comment on attachment 270557 [details] [diff] [review]
v1.0
>+ if (0 == dbSchemaVersion) {
|dbSchemaVersion == 0| please, per convention in this file.
r=me, sorry i didn't get to it sooner. i'd hit up biesi on irc for sr, tell him it's a 20 second review and he'll have it done within the hour ;)
Attachment #270557 -
Flags: review?(dwitte) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
r=dwitte
Attachment #270557 -
Attachment is obsolete: true
Attachment #271228 -
Flags: superreview?(cbiesinger)
|
||
Updated•19 years ago
|
Attachment #271228 -
Flags: superreview?(cbiesinger) → superreview+
|
|
||
Comment 4•19 years ago
|
||
checked in, thanks sdwilsh.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•