Closed Bug 386369 Opened 13 years ago Closed 13 years ago

Use getters and setters for database schema version

Categories

(Core :: Networking: Cookies, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file, 1 obsolete file)

Depends on: 386184
Depends on: 386366
No longer depends on: 386184
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Attached patch v1.0 (obsolete) — Splinter Review
not sure who a good sr is - please advise
Assignee: dwitte → sdwilsh
Attachment #270557 - Flags: review?(dwitte)
Comment on attachment 270557 [details] [diff] [review]
v1.0

>+    if (0 == dbSchemaVersion) {

|dbSchemaVersion == 0| please, per convention in this file.

r=me, sorry i didn't get to it sooner. i'd hit up biesi on irc for sr, tell him it's a 20 second review and he'll have it done within the hour ;)
Attachment #270557 - Flags: review?(dwitte) → review+
Attached patch v1.1Splinter Review
r=dwitte
Attachment #270557 - Attachment is obsolete: true
Attachment #271228 - Flags: superreview?(cbiesinger)
Attachment #271228 - Flags: superreview?(cbiesinger) → superreview+
checked in, thanks sdwilsh.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.