386463 - DebugQA extension packages locale files into the wrong file

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Frank Wein [:mcsmurf]]

With a current Windows SeaMonkey trunk build you get a undefined entity error when opening the Preferences window and selecting the Debug menu-point there. When taking a closer look at the DebugQA extension it seems that only the content/ files are packaged in there (bin/extensions/[e-mail]/chrome/debugqa.jar), but the locale files end up in bin/chrome/debugqa.jar (along with a bin/chrome/debugqa.manifest file).
Maybe the debugQA/locales/Makefile.in file needs some lines like XPI_NAME, etc. in it as Inspector has under http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/locale/Makefile.in#47. I did a quick test, which almost worked, but it still wrote the "locale debugQA ..." line to extensions/[e-mail]/chrome/debugqa.manifest instead of extensions/[e-mail]/chrome.manifest. Maybe another small trick is needed, suggestions?

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

This should fix it.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 270482 [details] [diff] [review]
Patch

Thanks for the patch Frank, I somehow totally missed that bit.

Comment 3

[Mark Banner (:standard8)]

Patch checked in, this should be fixed now.