Closed Bug 386531 Opened 13 years ago Closed 12 years ago

XPCOMUtilify console command line handler

Categories

(Toolkit Graveyard :: Error Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: rflint, Assigned: rflint)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch Patch (obsolete) — Splinter Review
Note that code evaluation is broken due to 385092.
Attachment #270521 - Flags: review?(mconnor)
The patch in bug 386536 might help to simplify this a bit more, if it gets accepted.
Comment on attachment 270521 [details] [diff] [review]
Patch

Canceling for now per comment 2.
Attachment #270521 - Flags: review?(mconnor)
Attached patch Patch (obsolete) — Splinter Review
Attachment #270521 - Attachment is obsolete: true
Attachment #270522 - Attachment is obsolete: true
Attachment #278023 - Flags: review?(mconnor)
Attached patch UpdatedSplinter Review
Attachment #278023 - Attachment is obsolete: true
Attachment #289877 - Flags: review?(mconnor)
Attachment #278023 - Flags: review?(mconnor)
Comment on attachment 289877 [details] [diff] [review]
Updated

diff -w always throws me off... :)
Attachment #289877 - Flags: review?(mconnor) → review+
Comment on attachment 289877 [details] [diff] [review]
Updated

Essentially just a cleanup - very little risk.
Attachment #289877 - Flags: approval1.9?
Attachment #289877 - Flags: approval1.9? → approval1.9+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M10
Product: Firefox → Toolkit
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.