386534 - FUEL: removeEventListener takes three params (NS_ERROR_XPC_NOT_ENOUGH_ARGS on shutdown)

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Nickolay_Ponomarev]

See the URL. You're missing a required third parameter (should be true, it seems).

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: added missing 3rd params to removeEventListener

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 271119 [details] [diff] [review]
added missing 3rd params to removeEventListener

>Index: fuelApplication.js

>-    if ((aData == "item-uninstalled") &&
>-        (aSubject instanceof Ci.nsIUpdateItem) &&
>-        (aSubject.id == this._item.id))
>+    if ((aSubject instanceof Ci.nsIUpdateItem) && (aSubject.id == this._item.id))
>     {
>-      this._events.dispatch("uninstall", this._item.id);
>+      if (aData == "item-uninstalled")
>+        this._events.dispatch("uninstall", this._item.id);

I'd rather you not make these changes. r=me with this hunk removed.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

whoops. removed the extra hunk before landing.