Closed Bug 386534 Opened 15 years ago Closed 15 years ago

FUEL: removeEventListener takes three params (NS_ERROR_XPC_NOT_ENOUGH_ARGS on shutdown)

Categories

(Firefox :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: asqueella, Assigned: mfinkle)

References

()

Details

Attachments

(1 file)

See the URL. You're missing a required third parameter (should be true, it seems).
Status: NEW → ASSIGNED
Assignee: nobody → mark.finkle
Attachment #271119 - Flags: review?(gavin.sharp)
Comment on attachment 271119 [details] [diff] [review]
added missing 3rd params to removeEventListener

>Index: fuelApplication.js

>-    if ((aData == "item-uninstalled") &&
>-        (aSubject instanceof Ci.nsIUpdateItem) &&
>-        (aSubject.id == this._item.id))
>+    if ((aSubject instanceof Ci.nsIUpdateItem) && (aSubject.id == this._item.id))
>     {
>-      this._events.dispatch("uninstall", this._item.id);
>+      if (aData == "item-uninstalled")
>+        this._events.dispatch("uninstall", this._item.id);

I'd rather you not make these changes. r=me with this hunk removed.
Attachment #271119 - Flags: review?(gavin.sharp) → review+
whoops. removed the extra hunk before landing.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.