Closed
Bug 386560
Opened 17 years ago
Closed 17 years ago
enable inspector support to work with --disable-xul
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
10.56 KB,
patch
|
benjamin
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Most of dom inspector's back-end support doesn't require XUL and I have a use for some of it. I also consider dom inspector's back-end support to be part of gecko and think it should always be built unless explicitly turned off. (I want this for x86/w32 and arm/linux, yes, I know that at present */osx is unhappy.)
Attachment #270553 -
Flags: superreview?(dbaron)
Attachment #270553 -
Flags: review?(benjamin)
Comment 1•17 years ago
|
||
Comment on attachment 270553 [details] [diff] [review] patch by daniel bainton This patch looks fine from a build POV, but I don't think we should be enabling the inspector APIs by default on small devices, so please let's not land the configure.in changes.
Attachment #270553 -
Flags: review?(benjamin) → review+
Comment on attachment 270553 [details] [diff] [review] patch by daniel bainton seeking sr from another layout peer.
Attachment #270553 -
Flags: review?(bzbarsky)
Comment 3•17 years ago
|
||
Comment on attachment 270553 [details] [diff] [review] patch by daniel bainton Looks ok if nsIBoxObject is really not MOZ_XUL.
Attachment #270553 -
Flags: superreview?(dbaron)
Attachment #270553 -
Flags: superreview+
Attachment #270553 -
Flags: review?(bzbarsky)
Comment on attachment 270553 [details] [diff] [review] patch by daniel bainton mozilla/layout/build/Makefile.in 1.165 mozilla/layout/build/nsLayoutModule.cpp 1.177 mozilla/layout/build/nsLayoutModule.cpp 1.178 mozilla/layout/build/nsLayoutStatics.cpp 1.34 mozilla/layout/build/nsLayoutStatics.cpp 1.35 mozilla/layout/inspector/src/Makefile.in 1.32
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•