386561 - Page not painting properly

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

See the url, you need to download the testcase to your computer, 
because of enhanced privileges.

Comment 1

[Martijn Wargers (dead)]

See bug 376426 for a similar problem, but different testcase.

Comment 2

[Daniel Veditz [:dveditz]]

In 1.8 branch bug 386354 this is listed as a regression, but that bug has not been checked in yet. Is it a regression from bug 373586 on trunk?

Is it likely to be a stop-ship issue? If so please nominate for blocking1.9

Is it the same as bug 376426 (which was filed after bug 373586 was fixed)?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

My *guess* is that this is not a regression but something which can be
seen now because bug 373586 (which fixes bug 386254 too) is fixed.
The patch for bug 386254 doesn't really change functionality, well, ok
editor may stay alive a bit longer.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Make sure that viewmanager's EndUpdateViewBatch gets called.
There is anyway null checks for selection, so better to not
return too early.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

The same patch works fine both in trunk and branches.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Because of bug 386254 adding blocking? flags.

Comment 7

[Peter Van der Beken [:peterv]]

Comment on attachment 270791 [details] [diff] [review]
proposed patch

Does it even make sense to warn?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Maybe not. That was more for my debugging.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: without the warning

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Unfortunately this is not the same problem as bug 376426. 

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 270926 [details] [diff] [review]
without the warning

Checked in to trunk.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 270926 [details] [diff] [review]
without the warning

approved for 1.8.1.5 and 1.8.0.13, a=dveditz for release-drivers

Comment 13

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5pre) Gecko/20070709 BonEcho/2.0.0.5pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.13pre) Gecko/20070710 Firefox/1.5.0.13pre

The page is still painting properly after clicking on the button. (I had to test the testcase in a chrome:// url, btw).
It doesn't even crash anymore ;)

Comment 14

[Martijn Wargers (dead)]

Also verified with current trunk build.