Closed Bug 386561 Opened 15 years ago Closed 15 years ago
Page not painting properly
See the url, you need to download the testcase to your computer, because of enhanced privileges.
See bug 376426 for a similar problem, but different testcase.
In 1.8 branch bug 386354 this is listed as a regression, but that bug has not been checked in yet. Is it a regression from bug 373586 on trunk? Is it likely to be a stop-ship issue? If so please nominate for blocking1.9 Is it the same as bug 376426 (which was filed after bug 373586 was fixed)?
My *guess* is that this is not a regression but something which can be seen now because bug 373586 (which fixes bug 386254 too) is fixed. The patch for bug 386254 doesn't really change functionality, well, ok editor may stay alive a bit longer.
Make sure that viewmanager's EndUpdateViewBatch gets called. There is anyway null checks for selection, so better to not return too early.
The same patch works fine both in trunk and branches.
Status: NEW → ASSIGNED
Component: Layout → Editor
Because of bug 386254 adding blocking? flags.
Comment on attachment 270791 [details] [diff] [review] proposed patch Does it even make sense to warn?
Maybe not. That was more for my debugging.
Unfortunately this is not the same problem as bug 376426.
Comment on attachment 270926 [details] [diff] [review] without the warning Checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 270926 [details] [diff] [review] without the warning approved for 22.214.171.124 and 126.96.36.199, a=dveditz for release-drivers
Verified fixed, using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:188.8.131.52pre) Gecko/20070709 BonEcho/184.108.40.206pre Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:220.127.116.11pre) Gecko/20070710 Firefox/18.104.22.168pre The page is still painting properly after clicking on the button. (I had to test the testcase in a chrome:// url, btw). It doesn't even crash anymore ;)
Also verified with current trunk build.
You need to log in before you can comment on or make changes to this bug.