386744 - "View Image" on <canvas> throws "Error: uncaught exception: Load of denied."

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070304 Minefield/3.0a7pre

Steps to reproduce:
1. Go to http://polyhedra.org/poly/.
2. Right click on the polyhedra on the right side of the page and choose "View Image".

Actual results:
Nothing happens. No image is shown and I get the following error in the Error Console:

Error: uncaught exception: Load of  denied.

Expected results:
Image is shown on separate page, as is done for normal images.

From IRC:
13:17 < dolske> the original should have added some code to viewImage() like it did to saveImage().

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch for review, v.1

The patch in bug 346849 which added this feature added code to allow "View Image" and "Save Image As" menu items on a <canvas>, but only implemented the "Save Image As" code.

This patch implements the "View Image" side of things.

[Currently awaiting a build to complete before testing, but seems simple enough.]

Comment 2

[Asaf Romano (gone)]

Comment on attachment 270752 [details] [diff] [review]
Patch for review, v.1

declare viewURL outside the if block and remove single line braces.

r=mano otherwise.

Comment 3

[Justin Dolske [:Dolske]]

Attachment: Patch, checked in

Checking in browser/base/content/nsContextMenu.js;
/cvsroot/mozilla/browser/base/content/nsContextMenu.js,v  <--  nsContextMenu.js
new revision: 1.16; previous revision: 1.15
done

Comment 4

[Jeff Walden [:Waldo]]

Litmus would be easiest here, although it could be automated with some trouble.

Comment 5

[Marcia Knous [:marcia]]

Litmus Triage Team: marcia will handle test case.

Comment 6

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=5009 has been added to cover this scenario.

Comment 7

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120305 Minefield/3.0b2pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007120304 Minefield/3.0b2pre.