Remove Firefox logo from javascript alert() sheets on Mac OS

VERIFIED FIXED in Firefox 3 beta3

Status

()

Firefox
Shell Integration
P2
normal
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: dveditz, Assigned: Kevin Gerich)

Tracking

Trunk
Firefox 3 beta3
PowerPC
Mac OS X
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sg:low spoof][has patch in bug 427935])

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
The security alias gets a steady stream of worried emails prompted by scam security-software ads that put up an alert() or confirm() announcing that "we" have detected porn and/or viruses and that the user should install ProductX to clean it up ("DriveCleaner" is the most common one lately, but they keep changing names).

Users on other platforms get the same ads, of course, but we mostly hear from the Mac users. On MacOSX these dialogs are "sheets" that slide out of our chrome like an infobar, and contain a big, prominent Firefox logo that seems to overwhelm any clarifying message we're trying to send with the "The site XXXX says" text.

Maybe we want to re-evaluate the dialog textual changes that were made in FF2 ("The site at xxxx says...") and see if that's working on all platforms (should it be bold? bigger? can we even do that given the frozen prompt interface?) and I think I saw another bug or discussion on that. But at the very least we should remove the prominent Firefox logo-of-approval from the mac prompts and replace it with platform-appropriate generic icons (or even nothing).

On windows these dialogs use the standard /!\ and (?) icons for alert and confirm/prompt respectively.
Flags: blocking-firefox3?
Created attachment 270774 [details]
Screencap of behaviour on Mac

I agree that this is undesirable.  I briefly entertained the notion of branding it with the site's favicon, but a) they are too small, and scaling would be ugly, and b) that opens up more spoofing options.

Comment 2

11 years ago
See also bug 386486, "Please put 'The page at [address] says:' somewhere other than the alert dialog's titlebar, or remove it".
Whiteboard: [sg:want P3]

Updated

11 years ago
Flags: blocking-firefox3? → blocking-firefox3+

Updated

11 years ago
Target Milestone: --- → Firefox 3 M9

Updated

11 years ago
Target Milestone: Firefox 3 M9 → Firefox 3 M10

Updated

11 years ago
Target Milestone: Firefox 3 M10 → Firefox 3 M11
This is a theme issue.  -> Kevin.
Assignee: joshmoz → kevin
Priority: -- → P3

Updated

11 years ago
Priority: P3 → P2
This is only an issue on OS X, since Windows and Linux both use an exclamation icon.  For parity should just use the platform exclamation icon (warning) on OS X, which is already listed on the icon inventory.

We have previously used the warning icon, as had IE6, but this doesn't actually make sense.  It seems like we should either be using the error icon or the information icon.

Error icon. The user interface (UI) is presenting an error or problem that has occurred.

Warning icon. The UI is presenting a condition that might cause a problem in the future.

Information icon. The UI is presenting useful information.

(from http://msdn2.microsoft.com/en-us/library/aa511277.aspx)

The correct icon really depends on how the web sites are using the alert.  I tend to think the information icon makes the most sense since it is more neutral than warning.  It's too bad the site can't specify which dialog icon makes the most sense given the message.
Note that bug 408869 changed the alert icon definition on mac to the same symbol used on windows so I guess will fix this.
Depends on: 408869
Correction, going to drop the global style change there and let this bug play out.
No longer depends on: 408869
(Reporter)

Updated

10 years ago
Whiteboard: [sg:want P3] → [sg:low spoof]
This still appears to be open on trunk.  I visited
javascript:alert('foo');

and still received the Minefield logo in the alert.

Tested using:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008020704 Minefield/3.0b4pre
We are thinking about using the information icon from the OS instead of the warning icon.  This is a deviation from how operating systems traditionally use the dialog icons (warning = something went wrong, information = thought you might want to know), however I think it results in a happier user experience.  Here is the distinction that I personally wish operating systems would take:

warning = computer made a mistake
information = user made a mistake, or thought you might want to know

So the overall reason I want to use the information icon is that throwing up the "you are about to drive off the road yellow sign with exclamation point" icon every time you put spaces in your credit card number, or you right click on an image that the site doesn't want you to be able to save, is just an overly angry way for the application to address the user.

After the change people will likely complain that we are violating various HIGs, we can point them to this comment for the rationale.

Created attachment 309149 [details]
Draft of Dialog icons for windows (luna and aero)

Here is the current iteration of the Information and Warning dialog icons for windows.  We will be landing the final files for beta 5.

Updated

10 years ago
Whiteboard: [sg:low spoof] → [sg:low spoof][needs status update]
removing uiwanted, the ui should be a standard information dialog icon.
Keywords: uiwanted
(In reply to comment #10)
> removing uiwanted, the ui should be a standard information dialog icon.

Alex, on Mac, I'm not clear on what icon we're referring to, here.  Has it landed yet?
>Has it landed yet?

They sent me the updated icons yesterday but it didn't include an information icon, I'll ping them about it.
(Assignee)

Updated

10 years ago
Depends on: 427935
(Assignee)

Comment 13

10 years ago
patch for this in Bug 427935
Given the current patch in 427935 contains these lines:

>RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/global/global.css,v
>retrieving revision 1.21
>diff -u -p -8 -r1.21 global.css
>--- toolkit/themes/pinstripe/global/global.css	7 Apr 2008 22:56:44 -0000	1.21
>+++ toolkit/themes/pinstripe/global/global.css	9 Apr 2008 06:21:45 -0000
>@@ -133,20 +133,32 @@ window.dialog { 
> /* ::::: alert icons :::::*/
> 
> .message-icon,
> .alert-icon,
> .error-icon,
> .question-icon {
>   width: 64px;
>   height: 64px;
>-  list-style-image: url("chrome://branding/content/icon64.png");
>+  list-style-image: url("chrome://global/skin/icons/information-64.png");
>   margin: 6px 20px 6px 6px !important;
> }
> 
>+.alert-icon {
>+  list-style-image: url("chrome://global/skin/icons/warning-64.png");
>+}
>+
>+.question-icon {
>+  list-style-image: url("chrome://global/skin/icons/error-64.png");
>+}
>+
>+.question-icon {
>+  list-style-image: url("chrome://global/skin/icons/question-64.png");
>+}

I agree that bug 427935 will fix this bug.  We could mark this one as a dup, but since it's really a subset, I guess we should just mark this one fixed when bug 427935 lands.
Summary: Remove Firefox logo from javascript alert() sheets → Remove Firefox logo from javascript alert() sheets on Mac OS
Whiteboard: [sg:low spoof][needs status update] → [sg:low spoof]

Updated

10 years ago
Whiteboard: [sg:low spoof] → [sg:low spoof][has patch in bug 427935]
(Assignee)

Comment 15

10 years ago
fixed by checkin of bug 427935
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 16

10 years ago
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042304 Minefield/3.0pre. 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.