386761 - Talkback is not compatible with Sunbird 0.7pre nightly builds

Status: VERIFIED FIXED

(Calendar :: Build Config, defect, P2)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.5pre) Gecko/20070703 Calendar/0.7pre

The Talkback extension is not compatible with Sunbird 0.7pre nightly builds and disabled. According to the install.rdf file it only works with Sunbird 0.5.

This might be due to Bug 373373, adding Chris Cooper to CC.

Comment 1

[Omar Bajraszewski]

Maybe it's a good time to start enabling Breakpad? Firefox changed Talkback to Breakpad. Thunderbird will do it very soon...

Comment 2

[Stefan Sitter [:ssitter]]

(In reply to comment #1)
Omar, Breakpad is not available on MOZILLA_1_8_BRANCH builds as far as I know. For TRUNK you already filed Bug 374235.

Comment 3

[Chris Cooper [:coop] (he/him)]

/me is confused based on the comments above. Is this 0.7pre build based on the 1.8 branch or on the trunk? I just want to make sure I fix up the right Talkback package.

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
Sunbird 0.7pre is based on the 1.8 branch.

Comment 6

[Chris Cooper [:coop] (he/him)]

I updated the min/max version for the Talkback extension in the Talkback package for the Sunbird 1.8 Linux last night and it seems to be working correctly (i.e. is enabled) now.

I'll fix up the Mac and Windows packages today.

Comment 7

[Stefan Sitter [:ssitter]]

Chris, any estimate when you'll have time to update the Talkback packages? 

Is the required change something that someone from the Calendar team with tinderbox access or stage access could take over?

Is the Talkback package identical except the min./max. versions? In this case it might be good to already set the min. version to 0.7pre and the max. version to 0.7 so that the package is still valid in a few months for the 0.7 release cycle.

Comment 8

[Chris Cooper [:coop] (he/him)]

I'll build the new packages now. Got distracted with the SeaMonkey Windows failure last week, sorry.

Yes, the package is identical except for the change in the install.rdf, so if you do require future changes, editing that file should make things go.

TBH, I'm not sure how the app handles the min/max versions when they are not strictly numerical. We can try setting it to 0.7 if you want. Like I said, it's a simple change and repack to undo it if it doesn't work.

Comment 9

[Chris Cooper [:coop] (he/him)]

I've changed the Talkback packages on all three platforms to have a min version of 0.7pre and a max version of 0.7.

Comment 10

[Stefan Sitter [:ssitter]]

Verified for Windows using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.6pre) Gecko/20070720 Calendar/0.7pre. 
The Talkback extension is installed and enabled. The version number still shows 0.5 and doesn't match the Sunbird version number but I'm sure we can live with that.

Comment 11

[Chris Cooper [:coop] (he/him)]

That is what I would expect, and is actually an accurate representation of what is going on, i.e. reusing a package originally compiled against 0.5.