386768 - Use mozIStorageConnection's BackupDB instead of the current (buggy) one

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Shawn Wilsher :sdwilsh]

Currently, nsNavHistory.cpp has a BackupDB method that doesn't quite work as expected.  It should be changed to use the new method in mozIStorageConnection.

Comment 1

[Dietrich Ayala (:dietrich)]

hrm, this assumes that there's a valid connection object. our use-case in places is when the sqlite file is corrupt, so we don't yet have a valid connection (OpenDatabase fails):

http://mxr.mozilla.org/seamonkey/source/toolkit/components/places/src/nsNavHistory.cpp#465

Comment 2

[Shawn Wilsher :sdwilsh]

Hurg!  That's an api flaw I think :/

Comment 3

[AndrewM]

Target Milestone says M11 (Beta 3); should that be?

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Hey...this was a lot more difficult than originally expected.

I ended up adding an invariant to InitDBFile, but it already existed before.

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 301993 [details] [diff] [review]
v1.0


> // nsNavHistory::InitDBFile
> nsresult
> nsNavHistory::InitDBFile(PRBool aForceInit)
> {
>+  if (aForceInit) {
>+    NS_ASSERTION(mDBConn,
>+                 "When forcing initialization, a database connection must exists!");
>+  }
>+

nit: s/exists/exist/

r=me, thanks!

Comment 6

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

(In reply to comment #5)
> nit: s/exists/exist/
Also documented this in the header file.

This is for checkin.

Comment 7

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
new revision: 1.246; previous revision: 1.245
Checking in toolkit/components/places/src/nsNavHistory.h;
new revision: 1.136; previous revision: 1.135

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv