Status

()

Core
XUL
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
After the popup reworking patch (bug 279703), calling
    gMenuPopup.showPopup(gTrigger, -1, -1, "popup", "topleft", "topleft");
causes the popup to be offset by 1. This is because the code in nsMenuPopupFrame::InitializePopupWithAnchorAlign is erroneously adding the -1 x and y values to the anchor position. It should be using 0.
(Assignee)

Comment 1

10 years ago
Created attachment 270963 [details] [diff] [review]
fix off by one error

Initialize mXPos and mYPos to 0 when -1 are passed in.
Attachment #270963 - Flags: superreview?(roc)
Attachment #270963 - Flags: review?(roc)
(Assignee)

Comment 2

10 years ago
Found this bug when creating the testcase in bug 279703 so no need for an extra test here. 
Flags: in-testsuite-
Attachment #270963 - Flags: superreview?(roc)
Attachment #270963 - Flags: superreview+
Attachment #270963 - Flags: review?(roc)
Attachment #270963 - Flags: review+
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.