386809 - nsCSSStruct* copy constructors no longer needed

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

The nsCSSStruct copy constructors aren't used anymore.  Making them private and not implemented (and thus not having compiler-generated ones either) will save a bit of codesize.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 270845 [details] [diff] [review]
patch

Looks reasonable.

Can the copy constructors for nsCSSValueList, nsCSSCounterData, and nsCSSQuotes also go?  If so, we could nix CSS_IF_COPY as well.

Comment 2

[Eli Friedman]

(In reply to comment #1)
> Can the copy constructors for nsCSSValueList, nsCSSCounterData, and nsCSSQuotes
> also go?  If so, we could nix CSS_IF_COPY as well.

No; they ultimately end up backing nsICSSRule::Clone, which is called by at least nsGenericHTMLElement::CopyInnerTo. (I'm not sure where else; some sort of smart code browser would be very helpful here.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Looks like Eli beat me to investigating, but yeah, I think there are a bunch of things that still use cloning style rules (which is done on the compressed structures).

So marking fixed, since I landed the above patch this morning.