386845 - <blocked> field should be <blocks>

Status: NEW

(Bugzilla :: Bugzilla-General, defect)

Description

[timeless]

<bugzilla version="3.0+" urlbase="https://bugzilla.mozilla.org/" maintainer="[e-mail]" exporter="[e-mail]">
...
<dependson>347662</dependson>
<dependson>386253</dependson>
<dependson>386332</dependson>
<blocked>347742</blocked>
<blocked>354102</blocked>

blocked is the wrong word, it should be "blocks". reported by DaveFr on irc.

Comment 1

[timeless]

Attachment: i think this might do it

Comment 2

[Frédéric Buclin]

Comment on attachment 270887 [details] [diff] [review]
i think this might do it

>Index: Bugzilla/Install/DB.pm

>+    $dbh->bz_rename_column('dependencies',
>+                           'dependencies_blocked_idx',
>+                           'dependencies_blocked_idx');

There is no such column. An index is not a column (and you wrote twice the same index).

Comment 3

[timeless]

ok, so how do i rename an index? :)

get_rename_indexes_ddl is all i can find, and its use isn't apparent given it's only used once....

Comment 4

[Max Kanat-Alexander]

I've always thought this, but I never thought it was important enough to change. :-) I'm glad somebody's doing it, but we should wait until after bug 385379.

Comment 5

[timeless]

Attachment: this should be closer

Comment 6

[Frédéric Buclin]

(In reply to comment #4)
> I've always thought this, but I never thought it was important enough to
> change.

I still don't think it worths it. And generating extra code (old_foo || new_foo) is pointless to me.

Comment 7

[Frédéric Buclin]

Comment on attachment 270908 [details] [diff] [review]
this should be closer

If you want to update some visual thing, i.e. something the user will see, I could accept it. But I don't want such changes in the backend code, especially because not all changes make sense. I also don't want to see the DB indexes to be altered for something a user will never see.

Comment 8

[Frédéric Buclin]

Unrelated to WebService

Comment 9

[Jesse Ruderman]

This tripped me up using QuickSearch.  I tried to search using "blocks:" but it wants me to use "blocked:".