Bustage build fix MOZ_XUL disabled

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Created attachment 270913 [details] [diff] [review]
Build fix

Building without MOZ_XUL (embedding-profile=minimal)
failed after fixing Bug 380872  and Bug 53901

In bug 53901
https://bugzilla.mozilla.org/attachment.cgi?id=265905

with r+ but not committed yet.
Attachment #270913 - Flags: superreview?(bzbarsky)
Attachment #270913 - Flags: review?(bzbarsky)
Comment on attachment 270913 [details] [diff] [review]
Build fix

Looks ok.
Attachment #270913 - Flags: superreview?(bzbarsky)
Attachment #270913 - Flags: superreview+
Attachment #270913 - Flags: review?(bzbarsky)
Attachment #270913 - Flags: review+
Er... I'd already reviewed this.  Why are you wasting my time with making me do things twice, exactly?

If all you need is to get things checked in, file the bug, put "[checkin needed]" in the status whiteboard, and attach a patch.  Or even simpler, ask on IRC.
Whiteboard: [checkin needed]
(Assignee)

Comment 3

12 years ago
>do things twice, exactly?

Not exactly, previous patch was for bug 53901, this new += Bug 380872

Sorry...
Keywords: checkin-needed
Whiteboard: [checkin needed]
Assignee: jag → romaxa
content/base/src/nsGenericElement.cpp 3.579
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

11 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.