Closed
Bug 386889
Opened 18 years ago
Closed 18 years ago
nsObjectLoadingContent should null-initialize mPendingInstantiateEvent (uninitialized memory read/jump)
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(1 file)
|
542 bytes,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
While loading the scriptaculous mochitest under valgrind (the one test in dom/tests/mochitest/ajax/scriptaculous/), I saw:
==21933== Conditional jump or move depends on uninitialised value(s)
==21933== at 0x66BBD3D: nsObjectLoadingContent::LoadObject(nsIURI*, int, nsCString const&, int) (nsObjectLoadingContent.cpp:747)
==21933== by 0x6767EBF: nsHTMLSharedObjectElement::StartObjectLoad(int) (nsHTMLSharedObjectElement.cpp:412)
==21933== by 0x67689A1: nsHTMLSharedObjectElement::BindToTree(nsIDocument*, nsIContent*, nsIContent*, int) (nsHTMLSharedObjectElement.cpp:250)
...
looks like mPendingInstantiateEvent should be null-initialized in the constructor. (This is pretty harmless given the code.)
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #270972 -
Flags: superreview?(cbiesinger)
Attachment #270972 -
Flags: review?(cbiesinger)
|
||
Updated•18 years ago
|
Attachment #270972 -
Flags: superreview?(cbiesinger)
Attachment #270972 -
Flags: superreview+
Attachment #270972 -
Flags: review?(cbiesinger)
Attachment #270972 -
Flags: review+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Flags: in-testsuite-
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•