386904 - DIST_FILES and DIST_CHROME_FILES not implemented for install:: target in config/rules.mk

Status: RESOLVED INVALID

Description

[Alexander Sack]

Created attachment 270967 [details] [diff] [review]
install:: for DIST_FILES and DIST_CHROME_FILES

-- Summary:

This patch implements DIST_FILES as well as DIST_CHROME_FILES install::
target.

 -- Evaluation:

DIST_FILES is now used in browser/app/Makefile.in to install
application.ini; however, DIST_FILES is only implemented for
libs::, but not for libs::.

In consequence, make install'ed installs of firefox now break
with missing application.ini file.

When writing this fix, it became obvious that DIST_CHROME_FILES
install: target is missing too ... though it doesn't cause any
problems because its not really used.

Comment 1

[Benjamin Smedberg]

Comment on attachment 270967 [details] [diff] [review]
install:: for DIST_FILES and DIST_CHROME_FILES

These need at least to be wrapped in "ifndef XPI_NAME", or else things that are built to dist/xpi-stage will end up being installed, which is incorrect

Comment 2

[Reed Loden [:reed] (use needinfo?)]

asac, think you could address review comments, please? :)

Comment 3

[Benjamin Smedberg]

The install target doesn't use rules.mk any more, INVALID.