Closed Bug 386917 Opened 15 years ago Closed 15 years ago

"Choose Application" from feed drop down menu doesn't work anymore

Categories

(Core :: XUL, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: martijn.martijn, Assigned: enndeakin)

References

()

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

When clicking on the "Choose Application" from the feed drop down menu, you should get the filepicker dialog. This stopped working as soon as the patch for bug 279703 got checked in.
This is because the command event now fires after the open attribute is already removed. This 'feature' needed for this is tricky to implement without it being hacky because the command needs to close the menu then open a modal dialog.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9beta1
select "Choose Application" and click "Subscribe Now", then you can choose application.
Attached patch add a state api to popups (obsolete) — Splinter Review
This allows the choose application dialog handling to check if the popup is being hidden. Martijn, does this patch fix what it needed here?
Yeah, that patch fixes it for me.
Attachment #275654 - Attachment is obsolete: true
Attachment #275974 - Flags: superreview?(bzbarsky)
Attachment #275974 - Flags: review?(mano)
Comment on attachment 275974 [details] [diff] [review]
add some code to the popup tests to check the state

in feedwriter you should probably get the state manually, from its boxObject. wrappedJSObject usage in this component is a can of worms (well, used to be).
Comment on attachment 275974 [details] [diff] [review]
add some code to the popup tests to check the state

With what mano said, sr=bzbarsky
Attachment #275974 - Flags: superreview?(bzbarsky) → superreview+
(In reply to comment #6)
> (From update of attachment 275974 [details] [diff] [review])
> in feedwriter you should probably get the state manually, from its boxObject.
> wrappedJSObject usage in this component is a can of worms (well, used to be).
>

OK I'll make that change, although in the future I'd rather reduce the number of calls to box object methods.
Comment on attachment 275974 [details] [diff] [review]
add some code to the popup tests to check the state

With that, r=mano.
Attachment #275974 - Flags: review?(mano) → review+
Attachment #276772 - Flags: approval1.9?
Attachment #276772 - Flags: approval1.9?
Attachment #275974 - Flags: approval1.9?
Comment on attachment 275974 [details] [diff] [review]
add some code to the popup tests to check the state

a1.9=dbaron
Attachment #275974 - Flags: approval1.9? → approval1.9+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.