386971 - expose editor from nsIAccEditableText

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch2

fix

Comment 2

[Ginn Chen]

Comment on attachment 271055 [details] [diff] [review]
patch2

I think we want [noscript] for editor.

Also there's a extra space.
+   *  @param startPos - start index of the text whose attributes are modified.
+   * @param endPos - end index of the text whose attributes are modified.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> (From update of attachment 271055 [details] [diff] [review])
> I think we want [noscript] for editor.

Why?

Comment 4

[Aaron Leventhal]

Surkov, noscript is just an extra level of security. There's no reason to allow an extension to get hold of an nsIEditor, so why let them? It's better to reduce the attack surface as they say.

Comment 5

[alexander :surkov (:asurkov)]

checked in with Ginn's comments

Comment 6

[Ginn Chen]

Does it work?

I got

./../html/nsHyperTextAccessible.h:74: warning: virtual nsresult nsHyperTextAccessible::GetEditor(nsIEditor**) was hidden
nsDocAccessible.h:128: warning:   by virtual already_AddRefed<nsIEditor> nsDocAccessible::GetEditor()
./../html/nsHyperTextAccessible.h:74: warning: virtual nsresult nsHyperTextAccessible::GetEditor(nsIEditor**) was hidden
./../html/nsHTMLFormControlAccessible.h:122: warning:   by virtual already_AddRefed<nsIEditor> nsHTMLTextFieldAccessible::GetEditor()
./../html/nsHyperTextAccessible.h:74: warning: virtual nsresult nsHyperTextAccessible::GetEditor(nsIEditor**) was hidden
./../xul/nsXULFormControlAccessible.h:175: warning:   by virtual already_AddRefed<nsIEditor> nsXULTextFieldAccessible::GetEditor()
./../html/nsHyperTextAccessible.h:74: warning: virtual nsresult nsHyperTextAccessible::GetEditor(nsIEditor**) was hidden
./../xforms/nsXFormsAccessible.h:155: warning:   by virtual already_AddRefed<nsIEditor> nsXFormsEditableAccessible::GetEditor()

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch3

Ginn, I'm not sure accessibleEditor is perfect name, but I can't think something better. Probably you will suggest more appropriate name.

Comment 8

[Ginn Chen]

what about GetAssociatedEditor?

Or maybe we can change
virtual already_AddRefed<nsIEditor> ns*Accessible::GetEditor()
to
GetEditorInternal()

Comment 9

[alexander :surkov (:asurkov)]

(In reply to comment #8)
> what about GetAssociatedEditor?

I like this.

> Or maybe we can change
> virtual already_AddRefed<nsIEditor> ns*Accessible::GetEditor()
> to
> GetEditorInternal()
> 

I thought about this but it leads to mass renaming. Also we have SetEditor/CheckForEditor() and I don't know how they should be renamed.

Comment 10

[alexander :surkov (:asurkov)]

Attachment: patch4

Comment 11

[alexander :surkov (:asurkov)]

checked in