386982 - Tab drag and drop indicator arrow out of alignment by 1 px

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Wayne Woods]

Attachment: Displays the dnd indicator alignment wrt tabs when set to 9px (bad) or 8 px (good) width

Starting with Mac Firefox 2, the tab drag and drop indicator has been 1px too far to the left with respect to the division between tabs.

I believe this is because the arrow was changed to 8px wide with the new theme, but the Pinstripe css still specifies it as 9px. And the actual png file that contains it (tabDragIndicator.png) is 11px wide. So the arrow isn't centred within the image, either in the original file or in the chrome. See attached image for an example.

Setting the width to 8px in the css (see the patch which follows) remedies this problem. But is there any reason not to shave the blank columns and rows off the original image too?

Comment 1

[Wayne Woods]

Attachment: Basic patch that remedies the problem

Comment 2

[u88484]

Hey wayne, you have to ask for review if this is ever going to be checked it ;)

Comment 3

[Wayne Woods]

Thanks Kurt :) I actually made it part of the tab code cleanup patch on bug 390979 (and included a trimming of the arrow image, too). I haven't changed anything here in case I'm told I can't include it there, but the patch there is still awaiting review.

Comment 4

[Wayne Woods]

Fixed as part of bug 390979.