Closed Bug 387057 Opened 18 years ago Closed 18 years ago

Themes should have same warning-UI as other addons

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 349603

People

(Reporter: sicking, Unassigned)

References

Details

In bug 343037 we concluded that we can't make themes 'safe' without breaking a lot of existing themes. And still then themes could do evil things such as change the labes on 'ok' and 'cancel' buttons in security UIs. So at a recent security meeting we decided to give installing themes the same 'scary' UI as installing extensions. IIRC this also means that the addon manager should treat themes as other addons. Once this is done we could even removed the code we currently has that attempts to block scripts in themes from executing. This would allow more powerful themes to be created.
Flags: blocking-firefox3?
We already have this (see bug 349603), the UI is governed by the same whitelist and install UI as extensions, as the original answer to bug 343037. Is there anything else we should do with the install experience to fulfill this? I'm quite in favour of enabling more powerful themes, FWIW.
Hmm.. sorry, i was under the impression that this wasn't done yet when we discussed it at security meeting. Closing this as a dup then.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Flags: blocking-firefox3?
Group: security
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.