387061 - Duplicate "Re:" when replying to attached *.eml message

Status: NEW

(Thunderbird :: Message Compose Window, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: 2.0.0.5pre (20070705)

For several mailing lists I'm on, I get digests which include each message as an attachment.  These show up as *.eml attachment in TB.  If I double-click such a message whose subject line already contains "Re:" and choose Reply from the message's window, I get a subject starting with "Re: Re:" in the composition window.  This problem only occurs when replying to attached *.eml messages.

Reproducible: Always

Steps to Reproduce:
1. Open an attached *.eml whose subject starts with "Re:".
2. Click Reply to open a new message composition window.
3. The subject of the this new reply contains "Re: Re:".
Actual Results:  
The "Re:" subject tag is duplicated.

Expected Results:  
It shouldn't be duplicated, just as it would not be for when replying to a non-attached message.

Comment 1

[Magnus Melin [:mkmelin]]

->NEW using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a7pre) Gecko/2007070803 Thunderbird/3.0a1pre ID:2007070803

Comment 3

[David Woolley]

Strictly speaking, the Re: isn't duplicate, but rather added.  It is failing to detect the original Re:.  E.g, if the original is actually "RE:", you get "Re: RE:".

Comment 4

[Jim Porter (:squib)]

The solution here is to make NS_MsgStripRE[1] scriptable and called from nsDummyMsgHeader.mime2DecodedSubject[2].

[1] http://mxr.mozilla.org/comm-central/source/mailnews/base/util/nsMsgUtils.h#128
[2] http://mxr.mozilla.org/comm-central/source/mail/base/content/msgHdrViewOverlay.js#2548

Comment 5

[Anirudh GP(:anirudhgp)]

Hey I'd like to try and work on this bug.  How do I begin?

Comment 6

[Jim Porter (:squib)]

(In reply to anirudh.gp from comment #5)
> Hey I'd like to try and work on this bug.  How do I begin?

How far have you gotten? Do you have a self-built version of Thunderbird? If not, do that first: https://developer.mozilla.org/en-US/docs/Simple_Thunderbird_build

Comment 7

[Anirudh GP(:anirudhgp)]

(In reply to Jim Porter (:squib) from comment #6)
> (In reply to anirudh.gp from comment #5)
> > Hey I'd like to try and work on this bug.  How do I begin?
> 
> How far have you gotten? Do you have a self-built version of Thunderbird? If
> not, do that first:
> https://developer.mozilla.org/en-US/docs/Simple_Thunderbird_build

Yes I built Thunderbird on my PC. This is my first bug for Thunderbird.

Comment 8

[Jim Porter (:squib)]

Then see comment 4. You'll want to move NS_MsgStripRE to an XPCOM interface, e.g. nsIMessenger, so that both JS and C++ can access the function. Then you'll need to update calls to NS_MsgStripRE wherever it's used.

Comment 9

[Anirudh GP(:anirudhgp)]

How do I move it to an xpcom interface?

Comment 10

[Jim Porter (:squib)]

Take a look at the implementation of FormatFileSize: http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.cpp#2138