Closed Bug 38713 Opened 24 years ago Closed 24 years ago

TakeFocus fails if batching is off

Categories

(Core :: DOM: Selection, defect, P2)

Product:
Core
Component:
DOM: Selection
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: akkzilla)

References

Details

(Whiteboard: [nsbeta2+] Have fix, awaiting checkin approval)

Attachments

(1 file)

A fix
1.44 KB, patch
Details | Diff | Splinter Review 
nsSelection::TakeFocus() returns NS_ERROR_FAILURE if batching is on.  I worked
around that earlier in the editor (see the comment in
nsHTMLEditor::DeleteSelection), but now that auto-copy is on, it's causing other
problems (I have some bugs which I'll mark dependant on this one) because the
only way the editor has of doing line-oriented operations is by moving the
selection, but changing the selection also triggers an unwanted autocopy, which
I can't prevent by turning batching on because then I'll hit the
NS_ERROR_FAILURE.
Blocks: 36559
m17
Severity: normal → major
Priority: P3 → P2
Target Milestone: --- → M17
Bug 36559, dependant on this one, has just been marked nsbeta2+; so this one
also needs to be.

Mike, maybe I can help with this?
Keywords: nsbeta2
putting back to m16
Target Milestone: M17 → M16
Putting on [nsbeta2+] radar for beta2 fix.
Whiteboard: [nsbeta2+]
I have a fix and will attach a patch.  Mike has blessed this in principle, but I
want to test the code a bit before checking it in.
Assignee: mjudge → akkana
Whiteboard: [nsbeta2+] → [nsbeta2+] Have fix, testing now
Attached patch A fix — — Splinter Review 

    
  
Status: NEW → ASSIGNED

    
  
Whiteboard: [nsbeta2+] Have fix, testing now → [nsbeta2+] Have fix, awaiting checkin approval

    
    

    
  
Fixed.  QA: there's no black-box way to verify this except by verifying 36559.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
    

    
  
I am verifying this bug as fixed, per Akkana. Bug number 29219 is fixed, as 
marked by Chris and double checked by myself. 


Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: