Closed Bug 387154 Opened 15 years ago Closed 15 years ago

[FIX]Bug 180085 has regressed

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch Proposed fixSplinter Review
The basic problem is that if the padding is close enough to the specified width we end up with a very small computed width as the basis for our kid's available width.  Then we subtract off the focuspadding, and get a negative number.  We clamp it to zero, _then_ proceed to divide up the extra width and increase the kid's available width.

The upshot is that the kid's available width ends up bigger than it should be.  Simply moving the "ensure it's not negative" code to after we've increased the available width makes things better.

This probably regressed on reflow branch at some point; likely when we started using the available width again for auto-sizing of blocks.
Attachment #271251 - Flags: superreview?(dbaron)
Attachment #271251 - Flags: review?(dbaron)
Comment on attachment 271251 [details] [diff] [review]
Proposed fix

r+sr=dbaron
Attachment #271251 - Flags: superreview?(dbaron)
Attachment #271251 - Flags: superreview+
Attachment #271251 - Flags: review?(dbaron)
Attachment #271251 - Flags: review+
Checked in.
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.