387159 - With several FF windows, closing the last window with multiple tabs with [X] on top right corner behaves not the same as File-Exit (close by clicking, Alt+F4, doesn't ask to save current tabs, doesn't show dialogue)

Status: NEW

(Firefox :: General, defect)

Description

[Balaji R]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070604 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070604 Minefield/3.0a7pre

with multiple tabs open and quit the Browser, Pressing [X] brings the Confirm Close dialog box, where as File-Exit brings in quit minefield dialog box, Its not Consistent.

Reproducible: Always

Steps to Reproduce:
1. 
2.
3.

Comment 1

[Mardeg]

You bet your arse it's different, as it should be.
I don't want ChatZilla closing on me just by pressing the [X] in the browser window, whereas if I want to properly close everything so I can run profile manager or safe mode, I'll use File-Exit

Comment 2

[Adam Guthrie]

Comment 1 sounds about right. Is this the correct behavior, Michael?

Comment 3

[cmtalbert]

I agree that we don't want the [X] close to act exactly the same as File->Exit
(especially in the Chatzilla case you outline), but I think that closing via
the [X] control should still ask the user whether or not to save the current
tabs.

This behavior has precedent in the "warn on closing multiple tabs" confirmation
dialog on Firefox 2.  This dialog is shown both when closing multiple tabs via
File->Exit and when closing via the [X] control.  The new "Save Current Tabs"
confirmation dialog should behave in the same manor.

Steps:
1. Open multiple tabs
2. Click the [X] control in the top right, note that you get the "Close
multiple tabs warning" confirmation dialog and not the "Save current tabs"
confirmation dialog
3. Click Cancel
4. Choose File->Exit
5. Note that you get the "Save current tabs" confirmation dialog

== Expected Behavior == 
If you perform these steps with Firefox 2, you will see the "warn on closing multiple tabs" confirmation dialog in each case. Therefore, in Firefox 3, you
should see the "Save current tabs" confirmation dialog in both cases.

I think this should be CONFIRMED.

Comment 4

[Carsten Book [:Tomcat]]

i agree with comment #3 -> confirmed

Comment 5

[Balaji R]

I like to add 1 step to Comment #3, 
1a. open another window ( New window, Chatzilla , error console etc..) any one.
    ( if you have only tabs without any other window open, its working fine).

Comment 6

[Wayne Mery (:wsmwk)]

bug 431654 a dupe?

Comment 7

[Thomas D. (:thomas8)]

I believe Bug 431654 is not a duplicate of this bug because that one reports /no/ warning at all whereas this one is about /different/ warnings.

This bug is still present in Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1.

Platform/OS -> all (I assume).
Improved Summary (explained below).

Step 1 should be more correctly described:
1 Have multiple tabs open only in the current window (you're about to close)
1a. Have one or more other windows open that do NOT have multiple tabs (Download Manager, Add-ons window, New window, Chatzilla, error console etc.)

Expected behaviour is better stated as:
- Regardless of any other open FF windows, if there is only ONE window with multiple tabs, it should use "Save current tabs" confirmation dialogue for both ways of exiting FF: Close Window by clicking [x] in upper-right corner AND File > Exit.

I think the current design is "only ask to save tabs when it's the *last window* that is being closed", which is confusing for the user. Until FF will be able to save multiple sessions, what we actually want is a warning for the last window *with lots of tabs*, regardless of any other open FF windows (without multiple tabs). I reckon the most frequent use case is when you have only "Download Manager" and your "last"  window with multiple tabs - we'd surely expect FF to ask for saving tabs!

Comment 8

[eyal gruss]

invalid due to Bug 592822?