Closed
Bug 387178
Opened 18 years ago
Closed 18 years ago
Fix nsFolderCharsetObserver leak
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mscott, Assigned: mscott)
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
5.96 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Startup thunderbird, then quit. We end up leaking nsFolderCharsetObserver.
I noticed this while looking through the leak log while tracking down the dom window leak.
Easy fix coming up.
|
Assignee | |
Comment 1•18 years ago
|
||
release the global ref when the folder observer is notified that xpcom is shutting down. The old code leaked because by the time we set gReleaseObserver, nsDBFolderInfo::ReleaseExternalReferences had been called on all dbfolder info objects.
Assignee: nobody → mscott
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•18 years ago
|
Attachment #271286 -
Flags: superreview?(bienvenu)
|
|
||
Comment 2•18 years ago
|
||
Comment on attachment 271286 [details] [diff] [review]
the fix
maybe nsnull instead of NULL, for purely aesthetic reasons :-)
Attachment #271286 -
Flags: superreview?(bienvenu) → superreview+
|
||
Updated•18 years ago
|
OS: Windows Vista → All
Hardware: PC → All
|
|
Assignee | |
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•