Closed Bug 387181 Opened 15 years ago Closed 15 years ago

Remove unneeded mozconfig options

Categories

(Release Engineering :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ispiked, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file)

The following two options for the mozconfig are unneeded:

ac_add_options --enable-libxul
ac_add_options --enable-places-bookmarks

rhelmer added these when he changed from argo-vm to this box, and I told him they were unneeded (in some bug comment), but they never got changed.

Removing these is good because:

a) If will remove unnecessary cruft from the mozconfig and make it less confusing.
b) We shouldn't add unnecessary dependencies to the mozconfig (i.e. if someone changes the default for one of these in configure.in, they'll have to update the mozconfig here).
c) Precedence: None of the other tinderboxen have these options in their mozconfigs.
Will be done after new ref platform is in use, and stable.
Priority: -- → P3
These are the defaults on all platforms:
ac_add_options --enable-canvas
ac_add_options --enable-svg

cairo-gtk2 is the only available toolkit on Linux, and "Pango is required for cairo gfx builds":
ac_add_options --enable-default-toolkit=cairo-gtk2
ac_add_options --enable-pango

So let's remove these options from mozconfig as well.
Care to provide a patch? All configs are in CVS.
Attached patch patchSplinter Review
On Linux, remove the options mentioned in comment 0 and comment 2.
On Mac, just remove svg and canvas.
On Windows, remove svg, canvas, and default-toolkit=cairo-windows.

Tested on Linux, where everything (svg, canvas, places) works fine.
Assignee: build → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #273824 - Flags: review?(benjamin)
Attachment #273824 - Flags: review?(benjamin) → review+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Summary: Remove unneeded mozconfig options from the new Linux ref. platform → Remove unneeded mozconfig options
No longer blocks: 408697
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.