Remove unneeded mozconfig options

RESOLVED FIXED

Status

Release Engineering
General
P3
normal
RESOLVED FIXED
11 years ago
5 years ago

People

(Reporter: Adam Guthrie, Assigned: Steffen Wilberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.29 KB, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
The following two options for the mozconfig are unneeded:

ac_add_options --enable-libxul
ac_add_options --enable-places-bookmarks

rhelmer added these when he changed from argo-vm to this box, and I told him they were unneeded (in some bug comment), but they never got changed.

Removing these is good because:

a) If will remove unnecessary cruft from the mozconfig and make it less confusing.
b) We shouldn't add unnecessary dependencies to the mozconfig (i.e. if someone changes the default for one of these in configure.in, they'll have to update the mozconfig here).
c) Precedence: None of the other tinderboxen have these options in their mozconfigs.
Will be done after new ref platform is in use, and stable.
Priority: -- → P3
(Assignee)

Comment 2

11 years ago
These are the defaults on all platforms:
ac_add_options --enable-canvas
ac_add_options --enable-svg

cairo-gtk2 is the only available toolkit on Linux, and "Pango is required for cairo gfx builds":
ac_add_options --enable-default-toolkit=cairo-gtk2
ac_add_options --enable-pango

So let's remove these options from mozconfig as well.

Comment 3

11 years ago
Care to provide a patch? All configs are in CVS.
(Assignee)

Comment 4

11 years ago
Created attachment 273824 [details] [diff] [review]
patch

On Linux, remove the options mentioned in comment 0 and comment 2.
On Mac, just remove svg and canvas.
On Windows, remove svg, canvas, and default-toolkit=cairo-windows.

Tested on Linux, where everything (svg, canvas, places) works fine.
Assignee: build → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #273824 - Flags: review?(benjamin)

Updated

11 years ago
Attachment #273824 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

11 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Summary: Remove unneeded mozconfig options from the new Linux ref. platform → Remove unneeded mozconfig options
Blocks: 408697
No longer blocks: 408697
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.