Closed
Bug 387218
Opened 17 years ago
Closed 17 years ago
Build bustage from bug 384374 landing
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.9alpha8
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
1.99 KB,
patch
|
dmosedale
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
Basically, the following code:
nsHandlerAppBase() NS_HIDDEN {}
causes g++ 3.3 to complain about unexpected '{' and missing ';' and so forth.
moving the constructors out of line makes life happy here.
Attachment #271336 -
Flags: superreview?(cbiesinger)
Attachment #271336 -
Flags: review?(dmose)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 271336 [details] [diff] [review] Like so r=dmose; thanks for the patch
Attachment #271336 -
Flags: review?(dmose) → review+
|
||
Comment 2•17 years ago
|
||
Comment on attachment 271336 [details] [diff] [review] Like so I'd move the colon to the line with the initializer, like in nsExternalHelperAppService's constructor
Attachment #271336 -
Flags: superreview?(cbiesinger) → superreview+
|
Assignee | |
Comment 3•17 years ago
|
||
Fixed, with that change.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
This file no longer exists in the source. And we build on g++ so --> Verified.
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•