Closed Bug 387264 Opened 15 years ago Closed 15 years ago
Is this a regression?
(In reply to comment #1) > Is this a regression? I don't think so. I've been using trunk builds for quite a while, and I use these bookmarklets a lot (especially shell). I've never had this problem. Note that, on one of my computers, I do not even use the sidebar with bookmarks. The symptom I saw on that one was that shell would not work at all. On the other computer, I tried the Bookmarks menu, that didn't work and then I tried the sidebar, and it worked. I did notice one other thing. For months, I would keep adding "shell" to the bookmarks and its name would not show up. I would add its name by using "Properties," and then it would disappear the next time I started Firefox. (I did not think that was worth reporting as a bug.) Recently this got better. The name is there. But this was not true of the other bookmarklets. And the present bug applies to all of them. So I don't think this is relevant.
(In reply to comment #2) > (In reply to comment #1) > > Is this a regression? > > I don't think so. I've been using trunk builds for quite a while, and I use > these bookmarklets a lot (especially shell). I've never had this problem. I don't understand. If you've never had this problem, and now you're having it, then it would be a regression. That's the definition of a regression - "it used to work but now it doesn't".
Oh. Sorry. Then it isn't a regression. I misunderstood. I am a psychology professor. In psychology, "regression" means that something existed before (e.g., temper tantrums in childhood), got better (e.g., someone grew up and stopped having temper tantrums), and then it goes back to the earlier state (e.g., an adult has a childish tantrum).
Ah, I see. You're right, that is the correct definition of "regression" (A->B->A, where A is a "buggy" state and B is the desired state). People (like me) tend to (perhaps erroneously) use it to mean any unintentional change in behavior B->A, where the original "A" might be the implied "before this software existed" or "before this feature was implemented". The fact that you haven't experienced the initial "A" state is usually not relevant to bug triagers :)
I think we mostly use the term in the way you describe in comment 4: a "regression testsuite" is a bunch of tests for previously fixed bugs intended to catch them should they come back ("regress"). But sometimes it's simply the opposite of "progression" -- we went backward, not forward -- used to distinguish "new" problems from ones that have been there all along. If we can pinpoint when a problem started we can find the change that caused it which can help tremendously in fixing it.
When I try to launch the Shell bookmarklet from the bookmark menu I don't get an error, but it gets blocked as a popup. Works fine when the bookmarklet is clicked on the personal toolbar though. A debug build from 20070703 worked fine, so July 3-5 might be the regression window (don't count on that). Although I'm not seeing quite what's described in comment 0. I don't get the security error dolske saw, does the menu have about:blank context rather than chrome now?
CC'd bz because he changed a CheckLoadURI* call in nsContentUtils with bug 310165 in that date range. As I said I dont' see the error message dolske did, but that's a CheckLoadURI type message
This is should recreate what I'm seeing. From a clean profile: 1) Drag "Linked Images" bookmarklet to bookmark toolbar. It's the 2nd one on https://www.squarefree.com/bookmarklets/pagelinks.html 2) Load http://people.mozilla.com/~dolske/testcase/387264/ 3) Click "Linked Images" bookmarklet ...and, oh, hey, that works fine. But if you create a folder on the toolbar, and move the bookmarklet into it, then it fails with a "popup blocked" notification bar and the console error. Weird. I didn't see the "popup blocked" bar originally, because I had set the pref to never show the bar. I'll try this out on a clean
Perhaps something changed in Places that would have caused this?
Component: Bookmarks → Places
QA Contact: bookmarks → places
regress between 20070704_0524 and 20070704_0857 (Win build) [range] http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1183551840&maxdate=1183564619 maybe no relation with Places, I think.
This makes Furl and probably some other popular web services not work from bookmark menu. This should block Firefox 3 because of that IMHO.
neil, perhaps caused by bug 279703?
Does it work with the patch in bug 388280?
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072323 Minefield/3.0a7pre ID:2007072323 seems to be fixed by bug#388280.
This is caused because command events from menus are now fired asynchronously which means that it no longer occurs during a user input event (mouse or keyboard). This caused the popup blocker to think that someone was trying to automatically open a popup. The fix in bug 388280 pushes the user input state onto the stack again.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Wow it's been inactive for quite a while :) Verified on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008060309 Firefox/3.0 and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9) Gecko/2008053008 Firefox/3.0
Status: RESOLVED → VERIFIED
Test cases 6092, 5943, 7452, 6852-6854, 6859-6860 and 6905 are already created for the 3.1 test run and 4134, 3985 5234-5236, 5242-5243 and 5291 for the 3.0 test run. Instead of updating each test case, I'm going to go ahead and flag this as in-litmus+.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.