387271 - Newsgroups list is reloaded every time (hostinfo.dat isn't loaded)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Markus Hossner]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; de; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a7pre) Gecko/200707072121 SeaMonkey/2.0a1pre

The newsgroups list is reloaded every time when opening the subscribe dialog cause the hostinfo.dat isn't loaded.

nsNntpIncomingServer::LoadHostInfoFile() loads the wrong file mNewsrcFilePath instead of mHostInfoFile and every time after reading a line mHasSeenBeginGroups is set back to PR_FALSE.

Reproducible: Always

Comment 1

[Markus Hossner]

Attachment: Patch

Patch fixes the problems mentioned above.

Comment 2

[David :Bienvenu]

Comment on attachment 271383 [details] [diff] [review]
Patch

this is a trunk-only problem, right? In other words, I messed this up when getting rid of nsFileSpec...thx for the patch!

Comment 3

[[e-mail]]

Comment on attachment 271383 [details] [diff] [review]
Patch

>-		if (strncmp(line,"begingroups", 11) == 0) {
>+		if (PL_strncmp(line,"begingroups", 11) == 0) {
And here I was thinking the latest fad was to use the CRT where possible.

Comment 4

[Karsten Düsterloh]

> And here I was thinking the latest fad was to use the CRT where possible.

See bug 379070 comment 161 and 166.

Comment 5

[Karsten Düsterloh]

Landed on trunk.

Comment 6

[[e-mail]]

(In reply to comment #4)
>>And here I was thinking the latest fad was to use the CRT where possible.
>See bug 379070 comment 161 and 166.
I meant CRT, not nsCRT i.e. strcmp isntead of nsCRT::strcmp :-P