387327 - Mozilla Thunderbird es-ES upgrade dialog is too narrow for current text

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[RickieES aka Ricardo Palomares]

This is somewhat a recurrent problem. The updater dialog ("Firefox|Thunderbird is installing your updates and will start in a few moments...") is too narrow for the current es-ES text and can't be resized, neither automatically nor with a preset size by localization.

Reproducible: Always

Steps to reproduce:

1. Install a previous Thunderbird version (for example, 2.0.0.0).
2. Check for updates. It should find a newer one (currently 2.0.0.4).
3. Update. On restarting, the dialog will appear.

Comment 1

[RickieES aka Ricardo Palomares]

Attachment: Current appearance of update dialog on Windows XP

The current problem as seen on Windows XP (but it also happens on Linux).

Comment 2

[RickieES aka Ricardo Palomares]

The ideal solution would probably be auto-resizing, a longer width with the message appearing centered, or a localization-supplied width. In the meanwhile, I've been testing with shorter messages and I've come up with one.

Comment 3

[RickieES aka Ricardo Palomares]

Attachment: Shorter message for update dialog

Patch with shorter text that prevents overflow.

Comment 4

[RickieES aka Ricardo Palomares]

Attachment: Appearance on Linux after applying the patch

Comment 5

[RickieES aka Ricardo Palomares]

Attachment: Appearance on Windows 2000 after applying the patch

Comment 6

[Andrés G. Aragoneses]

I prefer "y se ejecutará en breve.", that has the same size (notice about the lack of dots '...').

Comment 7

[Andrés G. Aragoneses]

Attachment: Same problem in Firefox

Can we make this bug wider? The same problems exists on Firefox (at least the last time it found an update).

Comment 8

[Andrés G. Aragoneses]

Attachment: My sample for thunderbird

I'm afraid we will need an ultra-short sentence to have it fixed everywhere. Something like "Thunderbird está actualizándose..." I guess.

Comment 9

[Axel Hecht [:Pike]]

This could be fixed by bug 336528, too. Should we rather see if we can get that one onto the branch instead of this one?

Comment 10

[RickieES aka Ricardo Palomares]

(In reply to comment #9)
> This could be fixed by bug 336528, too. Should we rather see if we can get that
> one onto the branch instead of this one?
> 


Of course, that would so much better, and solve future problems (it looks like even en-US has the same problem).

Comment 11

[Daniel Veditz [:dveditz]]

Code freeze for 2.0.0.5 is rapidly approaching (July 13) -- Axel do you want to approve this patch, or push on bug 336528 instead? Time is short.

Comment 12

[Scott MacGregor]

I'd rather us wait on 336528 FWIW. Just about every locale has this problem, not sure it makes sense to do a one of fix just for es-ES....

Comment 13

[RickieES aka Ricardo Palomares]

(In reply to comment #12)
> I'd rather us wait on 336528 FWIW. Just about every locale has this problem,
> not sure it makes sense to do a one of fix just for es-ES....
> 


I really favor it, too. The problem is just a cosmetic one, there is no functionality, no confusion for user, and approving this bug could force to approve others similar.

I guess the thing is if bug 336528 will make it in a reasonable time frame, and if it will be possible to land it on MOZILLA_1_8_BRANCH besides trunk.

Comment 14

[RickieES aka Ricardo Palomares]

I'm marking this bug as FIXED even if we don't actually change anything in es-ES localization, as bug 336528 has provided a general solution for all locales.

Comment 15

[Axel Hecht [:Pike]]

Comment on attachment 271446 [details] [diff] [review]
Shorter message for update dialog

[es-ES] a- for string change then, the underlying issue with the updater was fixed instead.