387342 - Nits in passwordmgr comments

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Sylvain Pasche]

Attachment: minor documentation corrections

I came across a few details while implementing the gnome-keyring module. For the first patch, devmo was not correct (it stops at the first one), I fixed the doc there (http://developer.mozilla.org/en/docs/New_in_JavaScript_1.6).

I separated the second one, as it only fixes indentation, without touching the comments.

Comment 1

[Sylvain Pasche]

Attachment: fixes indentation in .idl files

Comment 2

[Justin Dolske [:Dolske]]

I don't understand the .idl indentation patch... What changed?

Comment 3

[Sylvain Pasche]

(In reply to comment #2)
> I don't understand the .idl indentation patch... What changed?

It is about the number of spaces before the first star.

 /**
  *
  *
  ^-- star should be under the first star of the first line, not under the slash.

This is really a detail, but it makes the documentation look strange when you're not used to that style.

Comment 4

[Justin Dolske [:Dolske]]

Oh, duh, now I see it. That's what I get for looking at whitespace bugs at 3am! Yeah, this is absolutely the way comments should be indented; I probably missed this when I converted tabs to spaces.

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 271470 [details] [diff] [review]
fixes indentation in .idl files

Both patches look fine to me, I'll let gavin handle the 'official' review.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I don't think patches like these need "official review", but whatever, r=me for both ;)

Comment 7

[Nickolay_Ponomarev]

mozilla/toolkit/components/passwordmgr/public/nsILoginInfo.idl            1.2
mozilla/toolkit/components/passwordmgr/public/nsILoginManager.idl         1.3
mozilla/toolkit/components/passwordmgr/public/nsILoginManagerStorage.idl  1.4
mozilla/toolkit/components/passwordmgr/public/nsILoginManagerStorage.idl  1.5
mozilla/toolkit/components/passwordmgr/src/nsLoginManager.js              1.10