387454 - no version info in Minefield's xul.dll on Windows

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[skierpage]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070904 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007070904 Minefield/3.0a7pre

My nightly Minefield has an 8MB xul.dll file, but for some reason it has no Version information.

Reproducible: Always

Steps to Reproduce:
1. Right-click on C:\Program Files\Minefield\xul.dll, choose Properties
Actual Results:  
No Version tab, no version information; the Summary tab's fields are blank.

Expected Results:  
It would be useful to know what version of XULRunner/libxul Firefox uses.

Maybe this bug belongs in Toolkit/XULRunner.  But FWIW my Joost beta has a tiny C:\Program Files\Joost\xulrunner\xul.dll with full version info (1.9.20070.52311), so perhaps it's just the way Firefox builds libxul.

(*Congratulations* on XULRunner-based Firefox!)

Comment 1

[skierpage]

The XULRunner nightly build in http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/latest-trunk/ has the same issue; attempting to change to Toolkit/XULRunner.

Comment 3

[Benjamin Smedberg]

This is in fact not a duplicate. Fix forthcoming.

Comment 4

[Benjamin Smedberg]

Attachment: Use RCINCLUDE to get normal VERSIONINFO, rev. 1

Because we were using RESFILE the normal module.rc wasn't being used... this changes to use RCINCLUDE so that we combine the widget resources with the default version resource.

Comment 5

[Benjamin Smedberg]

Fixed on trunk.