Closed Bug 387503 Opened 17 years ago Closed 13 years ago

Make nsINode bits into an enum, move a macro into an inline function

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Macros suck, and debuggers don't cope with them well.
While you are here, it would be awesome if you could change NODE_TYPE_SPECIFIC_BITS_OFFSET to be:

#define NODE_TYPE_SPECIFIC_BITS_SIZE = 3
#define NODE_TYPE_SPECIFIC_BITS_OFFSET = (32 - NODE_TYPE_SPECIFIC_BITS_SIZE)

and change

nsGenericElement::GetScriptTypeID and nsGenericElement::SetScriptTypeID to use
((1 << NODE_SCRIPT_TYPE_SIZE) - 1) instead of 0x000f (3 places in total)
http://hg.mozilla.org/mozilla-central/rev/24559654b261
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: