Last Comment Bug 387503 - Make nsINode bits into an enum, move a macro into an inline function
: Make nsINode bits into an enum, move a macro into an inline function
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- minor (vote)
: mozilla1.9alpha8
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-09 17:45 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-01-23 01:06 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (4.27 KB, patch)
2007-07-09 17:45 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
no flags Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2007-07-09 17:45:52 PDT
Created attachment 271589 [details] [diff] [review]
Patch

Macros suck, and debuggers don't cope with them well.
Comment 1 Jonas Sicking (:sicking) No longer reading bugmail consistently 2007-07-09 18:05:58 PDT
While you are here, it would be awesome if you could change NODE_TYPE_SPECIFIC_BITS_OFFSET to be:

#define NODE_TYPE_SPECIFIC_BITS_SIZE = 3
#define NODE_TYPE_SPECIFIC_BITS_OFFSET = (32 - NODE_TYPE_SPECIFIC_BITS_SIZE)

and change

nsGenericElement::GetScriptTypeID and nsGenericElement::SetScriptTypeID to use
((1 << NODE_SCRIPT_TYPE_SIZE) - 1) instead of 0x000f (3 places in total)
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-01-23 01:06:41 PST
http://hg.mozilla.org/mozilla-central/rev/24559654b261

Note You need to log in before you can comment on or make changes to this bug.