Closed
Bug 387503
Opened 18 years ago
Closed 14 years ago
Make nsINode bits into an enum, move a macro into an inline function
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
4.27 KB,
patch
|
Details | Diff | Splinter Review |
Macros suck, and debuggers don't cope with them well.
While you are here, it would be awesome if you could change NODE_TYPE_SPECIFIC_BITS_OFFSET to be:
#define NODE_TYPE_SPECIFIC_BITS_SIZE = 3
#define NODE_TYPE_SPECIFIC_BITS_OFFSET = (32 - NODE_TYPE_SPECIFIC_BITS_SIZE)
and change
nsGenericElement::GetScriptTypeID and nsGenericElement::SetScriptTypeID to use
((1 << NODE_SCRIPT_TYPE_SIZE) - 1) instead of 0x000f (3 places in total)
|
||
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•