Make nsINode bits into an enum, move a macro into an inline function

RESOLVED FIXED in mozilla1.9alpha8

Status

()

Core
DOM
--
minor
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla1.9alpha8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 271589 [details] [diff] [review]
Patch

Macros suck, and debuggers don't cope with them well.
While you are here, it would be awesome if you could change NODE_TYPE_SPECIFIC_BITS_OFFSET to be:

#define NODE_TYPE_SPECIFIC_BITS_SIZE = 3
#define NODE_TYPE_SPECIFIC_BITS_OFFSET = (32 - NODE_TYPE_SPECIFIC_BITS_SIZE)

and change

nsGenericElement::GetScriptTypeID and nsGenericElement::SetScriptTypeID to use
((1 << NODE_SCRIPT_TYPE_SIZE) - 1) instead of 0x000f (3 places in total)
http://hg.mozilla.org/mozilla-central/rev/24559654b261
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.