Searchbar bindings depend on global pollution from printUtils.js

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
an hour ago

People

(Reporter: philor, Assigned: philor)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Created attachment 271616 [details] [diff] [review]
Fix v.1

Trying to make toolkit/components/printing/content/printUtils.js better-behaved by moving its |var XUL_NS =| out of the global scope (because it winds up conflicting with an even worse-behaved const in editor, in Thunderbird and SeaMonkey) pointed out to me that search.xml only works because printUtils.js defines XUL_NS for it. That seems... fragile.
Attachment #271616 - Flags: review?(gavin.sharp)
(Assignee)

Comment 1

12 years ago
Comment on attachment 271616 [details] [diff] [review]
Fix v.1

Oops, r-, doesn't follow the style of the rest of the file of defining a const and wrapping under 80 cols.
Attachment #271616 - Attachment is obsolete: true
Attachment #271616 - Flags: review?(gavin.sharp)
(Assignee)

Comment 2

12 years ago
Created attachment 271619 [details] [diff] [review]
Fix v.2
Attachment #271619 - Flags: review?(gavin.sharp)
Attachment #271619 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

12 years ago
browser/components/search/content/search.xml 1.96
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED

Updated

an hour ago
Blocks: 1509029
You need to log in before you can comment on or make changes to this bug.