Closed
Bug 387516
Opened 17 years ago
Closed 17 years ago
Searchbar bindings depend on global pollution from printUtils.js
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
RESOLVED
FIXED
People
(Reporter: philor, Assigned: philor)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.98 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Trying to make toolkit/components/printing/content/printUtils.js better-behaved by moving its |var XUL_NS =| out of the global scope (because it winds up conflicting with an even worse-behaved const in editor, in Thunderbird and SeaMonkey) pointed out to me that search.xml only works because printUtils.js defines XUL_NS for it. That seems... fragile.
Attachment #271616 -
Flags: review?(gavin.sharp)
|
Assignee | |
Comment 1•17 years ago
|
||
Comment on attachment 271616 [details] [diff] [review]
Fix v.1
Oops, r-, doesn't follow the style of the rest of the file of defining a const and wrapping under 80 cols.
Attachment #271616 -
Attachment is obsolete: true
Attachment #271616 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #271619 -
Flags: review?(gavin.sharp)
|
||
Updated•17 years ago
|
Attachment #271619 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
browser/components/search/content/search.xml 1.96
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•