Crash [@ nsNSSCertificate::GetCert fb3ac2be] on click submit on chrome://pippki/content/editcacert.xul



12 years ago
3 years ago


(Reporter: cbook, Assigned: kaie)


({crash, fixed1.8.0.13, verified1.8.1.8})

Bug Flags:
wanted1.8.1.x +
wanted1.8.0.x +

Firefox Tracking Flags

(Not tracked)


(crash signature, URL)


(2 attachments)



12 years ago
Steps to reproduce :

Load chrome://pippki/content/editcacert.xul into the browser. Check some boxes and click submit -> Crash.

Crash Trunk and Build. The Talkback Stack is from a Build since Breakpad doesn`t launch.

Stack Signature	 nsNSSCertificate::GetCert fb3ac2be
Product ID	Firefox2
Build ID	2007070403
Trigger Time	2007-07-04 21:06:30.0
Platform	Win32
Operating System	Windows NT 5.2 build 3790
Module	firefox.exe + (004849ea)
URL visited	crash while testing bug 379190
User Comments	
Since Last Crash	33494 sec
Total Uptime	33494 sec
Trigger Reason	Access violation
Source File, Line No.	c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/security/manager/ssl/src/nsNSSCertificate.cpp, line 882
Stack Trace 	
nsNSSCertificate::GetCert  [mozilla/security/manager/ssl/src/nsNSSCertificate.cpp, line 882]
nsNSSCertificateDB::SetCertTrust  [mozilla/security/manager/ssl/src/nsNSSCertificateDB.cpp, line 1002]
XPTC_InvokeByIndex  [mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp, line 102]
XPCWrappedNative::CallMethod  [mozilla/js/src/xpconnect/src/xpcwrappednative.cpp, line 2169]
XPC_WN_CallMethod  [mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp, line 1455]
js_Invoke  [mozilla/js/src/jsinterp.c, line 1375]
js_Interpret  [mozilla/js/src/jsinterp.c, line 3944]
js_Invoke  [mozilla/js/src/jsinterp.c, line 1394]
js_InternalInvoke  [mozilla/js/src/jsinterp.c, line 1469]
JS_CallFunctionValue  [mozilla/js/src/jsapi.c, line 4351]
nsJSContext::CallEventHandler  [mozilla/dom/src/base/nsJSEnvironment.cpp, line 1493]
nsJSEventListener::HandleEvent  [mozilla/dom/src/events/nsJSEventListener.cpp, line 195]
nsXBLPrototypeHandler::ExecuteHandler  [mozilla/content/xbl/src/nsXBLPrototypeHandler.cpp, line 513]
nsXBLKeyEventHandler::HandleEvent  [mozilla/content/xbl/src/nsXBLEventHandler.cpp, line 151]
nsEventListenerManager::HandleEventSubType  [mozilla/content/events/src/nsEventListenerManager.cpp, line 1655]
nsEventListenerManager::HandleEvent  [mozilla/content/events/src/nsEventListenerManager.cpp, line 1762]
nsXULElement::HandleDOMEvent  [mozilla/content/xul/content/src/nsXULElement.cpp, line 2232]
nsXULElement::HandleDOMEvent  [mozilla/content/xul/content/src/nsXULElement.cpp, line 2255]
nsXULElement::HandleDOMEvent  [mozilla/content/xul/content/src/nsXULElement.cpp, line 2255]
nsXULElement::HandleDOMEvent  [mozilla/content/xul/content/src/nsXULElement.cpp, line 2255]
PresShell::HandleEventInternal  [mozilla/layout/base/nsPresShell.cpp, line 6485]
PresShell::HandleEvent  [mozilla/layout/base/nsPresShell.cpp, line 6268]
nsViewManager::HandleEvent  [mozilla/view/src/nsViewManager.cpp, line 2521]
nsViewManager::DispatchEvent  [mozilla/view/src/nsViewManager.cpp, line 2253]
HandleEvent  [mozilla/view/src/nsView.cpp, line 174]
nsWindow::DispatchEvent  [mozilla/widget/src/windows/nsWindow.cpp, line 1319]
nsWindow::DispatchKeyEvent  [mozilla/widget/src/windows/nsWindow.cpp, line 3639]
nsWindow::OnKeyDown  [mozilla/widget/src/windows/nsWindow.cpp, line 3786]
nsWindow::ProcessMessage  [mozilla/widget/src/windows/nsWindow.cpp, line 4777]
nsWindow::WindowProc  [mozilla/widget/src/windows/nsWindow.cpp, line 1507]
USER32.dll + 0x172d8 (0x7d9472d8)
USER32.dll + 0x17568 (0x7d947568)
USER32.dll + 0x1778d (0x7d94778d)
USER32.dll + 0x177d0 (0x7d9477d0)
nsAppShell::Run  [mozilla/widget/src/windows/nsAppShell.cpp, line 159]
nsAppStartup::Run  [mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 152]
main  [mozilla/browser/app/nsBrowserApp.cpp, line 61]
kernel32.dll + 0x27d2a (0x7d4e7d2a)


12 years ago
Assignee: nobody → kengert
Component: Security → Security: UI
Product: Firefox → Core
QA Contact: firefox → ui

Comment 1

12 years ago
Bob, can you please review?

The context is slightly different on 1.8 branch and 1.8.0 branch, but the fix is the same, so I think a single review is sufficient. I'll attach another patch for the branches, though.
Attachment #271931 - Flags: review?(rrelyea)


12 years ago
Flags: blocking1.8.1.5?
Flags: blocking1.8.0.13?
Flags: blocking1.8.1.5? → blocking1.8.1.6?

Comment 3

12 years ago
Comment on attachment 271931 [details] [diff] [review]
Patch v1 (for trunk)

r= relyea
Attachment #271931 - Flags: review?(rrelyea) → review+

Comment 4

12 years ago
fixed on trunk
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 5

12 years ago
Comment on attachment 271931 [details] [diff] [review]
Patch v1 (for trunk)

requesting branch approval for trivial crash fix
Attachment #271931 - Flags: approval1.8.1.6?
Attachment #271931 - Flags: approval1.8.0.13?
Attachment #271931 - Flags: approval1.8.1.6? → approval1.8.1.7?
Not a blocker, but we'll look at the approval requests.
Flags: wanted1.8.1.x+
Flags: wanted1.8.0.x+
Flags: blocking1.8.1.7?
Flags: blocking1.8.0.13?
Attachment #271931 - Flags: approval1.8.1.7?
Attachment #271931 - Flags: approval1.8.0.13?
Comment on attachment 271932 [details] [diff] [review]
Patch v1 (applies to 1.8 branch and 1.8.0 branch)

approved for and, a=dveditz for release-drivers
Attachment #271932 - Flags: approval1.8.1.7+
Attachment #271932 - Flags: approval1.8.0.13+

Comment 8

12 years ago
fixed1.8.0.13, fixed1.8.1.7
TB crashes when start page is set to chrome://pippki/content/editcacert.xul.

See talkback ID TB34939402K.
Sorry, wrong TB ID...TB ID is TB35153242Z

Comment 11

12 years ago
(In reply to comment #10)
> Sorry, wrong TB ID...TB ID is TB35153242Z

Thats Bug 392208 / see comment#12 from Bug 379190
Well, then it masks this bug's fix so we cannot verify it.

Comment 13

12 years ago please use dependencies when things are blocked. please use this syntax: see bug 379190 comment 12
Depends on: 392208

Comment 14

12 years ago
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv: Gecko/20070903 BonEcho/ ID:2007090304 - no crash on steps to reproduce 

Adding verified keyword
Crash Signature: [@ nsNSSCertificate::GetCert fb3ac2be]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.