38764 - Background image on an inline element is repeated if element is displayed in multiple frames

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Charles Manske]

Start Composer. Click on Bold button and type some bold text.
Press Enter to break to a new line. Type some more.
Click on "Show All Tags" button at bottom of window to activate that mode.
This CSS is used to show a background image behind the text in the <b> element.
b {
  min-height: 35px; margin-left: 2px; margin-top: 2px;
  padding-left: 16px; 
  background: url(chrome://editor/content/images/tag-b.gif) no-repeat; 
  background-position: top left;
}

Note that the image is repeated on the second line even though the rule
is "norepeat"

I'll try to construct a simpler test example for viewer.

Comment 1

[Charles Manske]

Adding blocks

Comment 2

[Marc Attinasi]

Attachment: Testcase for use in viewer

Comment 3

[Marc Attinasi]

This is a layout problem. There is a continuing line and it is not respecting 
the no-repeat when it draws the background on the continued line. I'll take a 
stab at fixing this.

Setting milestone to match the blocked bug.

Comment 4

[Marc Attinasi]

OK - I have a fix for this that is actually in the CSSRendering code. 
PaintBackground now checks to see if the frame is a continuation, and if so, it 
makes sure the repeat-y value is set before painting in the background. Checking 
in... (nsCSSRendering.cpp)

Comment 5

[Marc Attinasi]

Fix checked in. (nsCSSRendering.cpp)

Comment 6

[Charles Manske]

Thanks. "you're the man".

Comment 7

[Chris Petersen]

Fixed in the May 23 build.

Comment 8

[Chris Petersen]

Oops. I mean the May 22nd builds (Mac, Win 98, Linux).

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Note that my patch to bug 14777 will back out this fix, though the problem as
originally described will not regress. (I've tested editor's all tags mode with
my proposed patch to verify this)