Closed
Bug 387649
Opened 17 years ago
Closed 17 years ago
To include Flash 9 plugin for Solaris in Plugin Finder service
Categories
(addons.mozilla.org Graveyard :: Plugins, enhancement)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: morgamic)
Details
Flash 9 for Solaris is released today. Wish we can have it included in Plugin Finder service. EULA: http://www.adobe.com/products/eulas/players/flash/ XPI files: SPARC: http://download.macromedia.com/pub/flashplayer/xpi/current/flashplayer-solaris-sparc.xpi X86: http://download.macromedia.com/pub/flashplayer/xpi/current/flashplayer-solaris-x86.xpi OS Name is SunOS Processor type is sparc or i386. OS Version requires 5.10 or 5.11 I'm not sure if we have OS version check in Plugin Finder service.
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → morgamic
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•17 years ago
|
||
It's based off the user-agent string. So we'd have to verify what it was in the client. Do you know for sure what the user-agent string looks like for SunOS?
Assignee | ||
Comment 2•17 years ago
|
||
From what I've seen, you can actually do a check for "SunOS 5\.1[0-9]" and that should be the correct check. I will test that.
Assignee | ||
Comment 3•17 years ago
|
||
Looks like the trick will be switching based on processor type. Can you guys drop me UA strings from each respective client?
If it's only based on UA, I think we have a problem, because the Solaris version information is not in UA. We need to do something to make sure Solaris 8/9 users won't have Flash 9 plugin installed by accident through Plugin Finder service. Maybe warn user in the plugin name or somewhere in the UI? UA string of Solaris are like, Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1.1) Gecko/20061228 Firefox/2.0.0.1 (can be sun4v instead of sun4u on UltraSparc T1) Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.8) Gecko/20051130 Firefox/1.5
Assignee | ||
Comment 6•17 years ago
|
||
Hey Ginn. We'll have to find a way to get the client os information to make sure 8/9 users don't get flash 9 and enter a world of hurt. So can you help me by using the Tamper Data extension to view the PFS request when you try to load a flash object on a page? You can get it here: https://addons.mozilla.org/en-US/firefox/addon/966 What I'm looking for is the CLIENT_OS value from the pfs.datasource.url from both 8/9 users and 10 users so I can make sure we get the right detection. The URL will look like this: https://pfs.mozilla.org/...&clientOS=%CLIENT_OS% You can test this by opening any flash object on a client without flash installed. To get tamper data, you'll have to download it and start it fromt he Tools menu. Then search for pfs.mozilla.org and paste me the URL it sends.
Michael, unfortunately the CLIENT_OS only contains sysname and machinename as same as UA string. e.g. SunOS sun4u I can verify the release level, i.e 5.10, 5.11 inside install.js after user downloads the xpi, to make sure we don't hurt Solaris 8/9 user. Do you like this plan? If you agree, I can start working on the xpi files. Thanks!
Assignee | ||
Comment 8•17 years ago
|
||
(In reply to comment #7) > I can verify the release level, i.e 5.10, 5.11 inside install.js after user > downloads the xpi, > to make sure we don't hurt Solaris 8/9 user. So the user would get a warning if they downloaded it and tried to install it w/ 8/9? If so that's a good alternative. We should verify that it doesn't install though.
Michael, My proposal is, 1) In Plugin Finder Service dialog, we use something like "Adobe Flash Player for Solaris 10 or above" as plugin name. So user of S8/9 will get noticed. 2) If user accept the EUAL and click next, the xpi will get downloaded. Before copying files to $HOME/.mozilla/plugins, it will check user's OS information, if no match, it will abort as install failed. Sounds good?
Assignee | ||
Comment 10•17 years ago
|
||
Sounds good. Will get this up by end of week. Thanks Ginn.
Reporter | ||
Comment 11•17 years ago
|
||
XPIs were updated with Solaris version check at same URLs.
Comment 12•17 years ago
|
||
Mike, any news on this one?
Reporter | ||
Comment 13•17 years ago
|
||
Michael, any news?
Assignee | ||
Comment 14•17 years ago
|
||
Ginn, added flash for Solaris -- will need help testing this on stage. Can you change pfs.datasource.url to: https://remora.stage.mozilla.com/services/pfs.php?mimetype=%PLUGIN_MIMETYPE%&appID=%APP_ID%&appVersion=%APP_VERSION%&clientOS=%CLIENT_OS%&chromeLocale=%CHROME_LOCALE% From there we should be able to test for both sparc and x86. If all looks good, we can push it to prod. Thanks, and sorry it took a while to get to this.
Assignee | ||
Comment 15•17 years ago
|
||
This was pushed.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 17•17 years ago
|
||
Awesome! :)
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•