387678 - Warnings thrown when running ./runtests -v 11

Status: RESOLVED FIXED

(Bugzilla :: Documentation, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

*** WARNING: empty section in previous paragraph at line 65 in file Bugzilla/User/Setting/Skin.pm
*** WARNING: Verbatim paragraph in NAME section at line 217 in file Bugzilla/Search/Saved.pm
*** WARNING: line containing nothing but whitespace in paragraph at line 433 in file Bugzilla/Install/Util.pm

The last warning only affects 3.1 as Bugzilla/Install/Util.pm doesn't exist in 3.0.

Comment 1

[David Lawrence [:dkl]]

Comment on attachment 271830 [details] [diff] [review]
patch, v1

>Index: Bugzilla/Install/Util.pm
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v
>retrieving revision 1.5
>diff -3 -p -u -r1.5 Util.pm
>--- Bugzilla/Install/Util.pm	5 May 2007 19:50:55 -0000	1.5
>+++ Bugzilla/Install/Util.pm	11 Jul 2007 13:56:36 -0000
>@@ -430,7 +430,7 @@ This allows for localization of strings
> Let's say your template string looks like this:
> 
>  The ##animal## jumped over the ##plant##.
>- 
>+
> Let's say that string is called 'animal_jump_plant'. So you call the function
> like this:
> 

What really changed in Util.pm? Seems like some whitespace changed causing
this to be included. If this wasn't necessary please fix so that the patch
does not include this file.

Otherwise looks good. Applies cleanly, perldoc works, and is consistent with
other module documentation style.

Dave

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 271830 [details] [diff] [review]
patch, v1

Ok. Now that I have updated my test box to the latest version of Perl and therefore the latest version of Pod::Checker, everything is now clean when the
patch is applied.

[dkl@bugdev mozilla-head]$ podchecker Bugzilla/User/Setting/Skin.pm 
*** WARNING: empty section in previous paragraph at line 65 in file Bugzilla/User/Setting/Skin.pm
Bugzilla/User/Setting/Skin.pm pod syntax OK.
[dkl@bugdev mozilla-head]$ podchecker Bugzilla/Search/Saved.pm 
*** WARNING: Verbatim paragraph in NAME section at line 217 in file Bugzilla/Search/Saved.pm
Bugzilla/Search/Saved.pm pod syntax OK.
[dkl@bugdev mozilla-head]$ podchecker Bugzilla/Install/Util.pm 
*** WARNING: line containing nothing but whitespace in paragraph at line 433 in file Bugzilla/Install/Util.pm
Bugzilla/Install/Util.pm pod syntax OK.
[dkl@bugdev mozilla-head]$ patch -p0 < /tmp/bug0-cvs.diff 
patching file Bugzilla/User/Setting/Skin.pm
patching file Bugzilla/Search/Saved.pm
patching file Bugzilla/Install/Util.pm
[dkl@bugdev mozilla-head]$ podchecker Bugzilla/User/Setting/Skin.pm 
Bugzilla/User/Setting/Skin.pm pod syntax OK.
[dkl@bugdev mozilla-head]$ podchecker Bugzilla/Search/Saved.pm 
Bugzilla/Search/Saved.pm pod syntax OK.
[dkl@bugdev mozilla-head]$ podchecker Bugzilla/Install/Util.pm 
Bugzilla/Install/Util.pm pod syntax OK.

r=dkl

Comment 3

[Frédéric Buclin]

tip:

Checking in Bugzilla/Install/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Util.pm,v  <--  Util.pm
new revision: 1.6; previous revision: 1.5
done
Checking in Bugzilla/Search/Saved.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v  <--  Saved.pm
new revision: 1.5; previous revision: 1.4
done
Checking in Bugzilla/User/Setting/Skin.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User/Setting/Skin.pm,v  <--  Skin.pm
new revision: 1.3; previous revision: 1.2
done


3.0:

Checking in Bugzilla/Search/Saved.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v  <--  Saved.pm
new revision: 1.3.2.1; previous revision: 1.3
done
Checking in Bugzilla/User/Setting/Skin.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User/Setting/Skin.pm,v  <--  Skin.pm
new revision: 1.1.2.2; previous revision: 1.1.2.1
done