I've been implementing block scope (let), and needed to use the reportMatch function to generalize tests for both SpiderMonkey and Rhino error messages. See attached patch. If don't see any issues with the patch I can commit it.
I did a quick look and it looks fine, but can we hold off for a day or so? I am hopefully in the final stages of getting regression and fix detection working for Spidermonkey and don't want to mess up the failure messages at the moment. As soon as I get the regression and fix detection working, I'll review and check in. Ok?
Sounds good, thanks!
Bob, Can I commit these changes yet? Thanks, Norris
I'm running a set of shell tests on 1.8.1, 1.9.0 with this patch applied. I'll let you know in ~hour?
Comment on attachment 271860 [details] [diff] [review] Patch for changes to tests results look fine. please go ahead and check in.
Attachment #271860 - Flags: review+
Fixed: Checking in js1_7/block/regress-348685.js; /cvsroot/mozilla/js/tests/js1_7/block/regress-348685.js,v <-- regress-348685.js new revision: 1.4; previous revision: 1.3 done Checking in js1_7/block/regress-349507.js; /cvsroot/mozilla/js/tests/js1_7/block/regress-349507.js,v <-- regress-349507.js new revision: 1.4; previous revision: 1.3 done Checking in js1_7/block/regress-350279.js; /cvsroot/mozilla/js/tests/js1_7/block/regress-350279.js,v <-- regress-350279.js new revision: 1.4; previous revision: 1.3 done Checking in js1_7/block/regress-351497.js; /cvsroot/mozilla/js/tests/js1_7/block/regress-351497.js,v <-- regress-351497.js new revision: 1.3; previous revision: 1.2 done Checking in js1_7/block/regress-352212.js; /cvsroot/mozilla/js/tests/js1_7/block/regress-352212.js,v <-- regress-352212.js new revision: 1.3; previous revision: 1.2 done Checking in js1_7/block/regress-352609.js; /cvsroot/mozilla/js/tests/js1_7/block/regress-352609.js,v <-- regress-352609.js new revision: 1.4; previous revision: 1.3 done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.