387703 - Inconsistent display of ASCII text

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Currently on Linux the ASCII path takes an Xft "fast path" which does no kerning, but the Unicode textrun construction path always uses Pango. The latter can use kerning while the former never does. This is a problem for reftests, among other things.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think I'll fix this by having MakeTextRun(const PRUnichar*) set TEXT_IS_8BIT always if the text really is 8-bit. This can be done efficiently by expanding its AppendUTF16toUTF8 loop.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 3

[Jo Hermans]

Are you sure you've attached the right attachment ? This seems to be another fix : i was never incremented, so FindFirstLetterRange() was stuck in an endless whole-loop.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: right patch

Sorry yeah, this is the right patch

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This causes reftest failures in at least some Pango configurations.