Closed Bug 387703 Opened 14 years ago Closed 14 years ago

Inconsistent display of ASCII text

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently on Linux the ASCII path takes an Xft "fast path" which does no kerning, but the Unicode textrun construction path always uses Pango. The latter can use kerning while the former never does. This is a problem for reftests, among other things.
I think I'll fix this by having MakeTextRun(const PRUnichar*) set TEXT_IS_8BIT always if the text really is 8-bit. This can be done efficiently by expanding its AppendUTF16toUTF8 loop.
Attached patch fix (obsolete) — Splinter Review
Attachment #271936 - Flags: review?(pavlov)
Are you sure you've attached the right attachment ? This seems to be another fix : i was never incremented, so FindFirstLetterRange() was stuck in an endless whole-loop.
Attached patch right patchSplinter Review
Sorry yeah, this is the right patch
Attachment #271936 - Attachment is obsolete: true
Attachment #272078 - Flags: review?(pavlov)
Attachment #271936 - Flags: review?(pavlov)
Attachment #272078 - Flags: review?(pavlov) → review+
checked in
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Summary: Inconsistent dispay of ASCII text → Inconsistent display of ASCII text
This causes reftest failures in at least some Pango configurations.
Flags: in-testsuite? → in-testsuite+
Blocks: 386759
You need to log in before you can comment on or make changes to this bug.