387720 - Shift-tab doesn't always work with textboxes (focusing textboxes?)

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Nickolay_Ponomarev]

Open:

<?xml version="1.0"?>
<?xml-stylesheet href="chrome://global/skin/"?>

<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

        <textbox id="a1"/>
        <textbox id="a2"/>
</window>

as top-level window. Focus the "a2" textbox and try to tab backwards via Shift+Tab (at least that's how you do it on Windows). Actual results: nothing happens. Expected: "a1" is focused.

Note that advancing focus forward works fine. Also note that this seems to be <textbox>-specific. If a1 is a checkbox, you can Shift-tab from a2->a1, but not from a1->a2. Similarly if a2 is a checkbox and a1 is a textbox, you can't Shift-tab to the textbox.

Regression range: 2007-07-04-04 - 2007-07-04-05

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-07-04+02%3A00%3A00&maxdate=2007-07-05+06%3A00%3A00&cvsroot=%2Fcvsroot

I see smaug touched editor in that window, so CCing.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Could you upload the testcase as an attachment.

Comment 2

[Nickolay_Ponomarev]

Attachment: testcase

Sure, but the bug isn't that obvious when the testcase is opened in content.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I backed out bug 386820 and  bug 386561 locally but that didn't
fix the problem.

Comment 4

[Nickolay_Ponomarev]

Hmm. My next guess is Neil then :)

Comment 5

[Neil Deakin]

Attachment: step back over popups

Only partially a regression. This bug has actually always been there, but changes to the popup frame code make it now possible to notice it.

When getting the last child, skip backwards over popup frames instead of forwards.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Neil, could you please add the CVS output as comment after a check-in? Thanks.

2007-07-12 06:54 mozilla/layout/base/nsFrameTraversal.cpp 3.59

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That also happened for Linux. It is fixed now with todays trunk nightly.