Closed
Bug 387726
Opened 17 years ago
Closed 17 years ago
nsIXULAppInfo.platformVersion contains extra unknown characters
Categories
(Toolkit Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
759 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Since fairly recently (I'd take a stab at bug 383167 but haven't verified) nsIXULAppInfo.platformVersion is now returning a 19 character string. This is "1.9a7pre" followed by 11 null characters. I've verified this on Windows and OSX, both on current Minefield nightlies. Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007071004 Minefield/3.0a7pre ID:2007071004
|
Assignee | |
Comment 1•17 years ago
|
||
Apparently AssignLiteral shouldn't be used with a character array. This resolves the issue.
|
||
Comment 2•17 years ago
|
||
Comment on attachment 272944 [details] [diff] [review] patch rev 1 Whoops, you're right.
Attachment #272944 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checking in toolkit/xre/nsAppRunner.cpp; /cvsroot/mozilla/toolkit/xre/nsAppRunner.cpp,v <-- nsAppRunner.cpp new revision: 1.182; previous revision: 1.181 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite?
|
|
Assignee | |
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9beta1
|
||
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•